chrome/browser/web_resource/promo_resource_service.cc - Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_resource/promo_resource_service.cc

Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments. Fix Clang build and fix bug shown by trybots. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/upgrade_detector.cc ('K') | « chrome/browser/web_resource/promo_resource_service.h ('k') | chrome/chrome_browser.gypi » ('j') | chrome/test/base/testing_pref_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/web_resource/promo_resource_service.cc

diff --git a/chrome/browser/web_resource/promo_resource_service.cc b/chrome/browser/web_resource/promo_resource_service.cc

index 1c7282cbd9a180ac9576c68f9e3fbeac578ed5ad..b336224a31d7d8fc19dfacbda92e966be42a9a94 100644

--- a/chrome/browser/web_resource/promo_resource_service.cc

+++ b/chrome/browser/web_resource/promo_resource_service.cc

@@ -10,7 +10,8 @@

#include "base/threading/thread_restrictions.h"

#include "base/values.h"

#include "chrome/browser/browser_process.h"

-#include "chrome/browser/prefs/pref_service_simple.h"

+#include "chrome/browser/prefs/pref_registry_simple.h"

+#include "chrome/browser/prefs/pref_service.h"

Mattias Nissler (ping if slow) 2013/01/31 14:50:45 required?

Jói 2013/01/31 16:23:37 Done.

#include "chrome/browser/prefs/pref_service_syncable.h"

#include "chrome/browser/web_resource/notification_promo.h"

#include "chrome/common/chrome_notification_types.h"

@@ -61,9 +62,9 @@ int GetCacheUpdateDelay() {

} // namespace

// static

-void PromoResourceService::RegisterPrefs(PrefServiceSimple* local_state) {

- local_state->RegisterStringPref(prefs::kNtpPromoResourceCacheUpdate, "0");

- NotificationPromo::RegisterPrefs(local_state);

+void PromoResourceService::RegisterPrefs(PrefRegistrySimple* registry) {

+ registry->RegisterStringPref(prefs::kNtpPromoResourceCacheUpdate, "0");

+ NotificationPromo::RegisterPrefs(registry);

}

// static

« chrome/browser/upgrade_detector.cc ('K') | « chrome/browser/web_resource/promo_resource_service.h ('k') | chrome/chrome_browser.gypi » ('j') | chrome/test/base/testing_pref_service.h » ('J')