Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 1173963002: X87: Vector ICs: debugger should save registers for vector store ics. (Closed)

Created:
5 years, 6 months ago by chunyang.dai
Modified:
5 years, 6 months ago
Reviewers:
Weiliang
CC:
v8-dev, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Vector ICs: debugger should save registers for vector store ics. port bd32a9f711cb14c2b7c34512d43e78bd24960124 (r28825). original commit message: BUG= R=weiliang.lin@intel.com Committed: https://chromium.googlesource.com/v8/v8/+/2dd269f39ae6ceb5bdd040dae3a71980a1e652c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M src/x87/debug-x87.cc View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
chunyang.dai
PTAL.
5 years, 6 months ago (2015-06-11 08:43:01 UTC) #2
Weiliang
lgtm
5 years, 6 months ago (2015-06-11 09:01:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173963002/1
5 years, 6 months ago (2015-06-11 09:01:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/1221)
5 years, 6 months ago (2015-06-11 09:27:23 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2dd269f39ae6ceb5bdd040dae3a71980a1e652c2 Cr-Commit-Position: refs/heads/master@{#28950}
5 years, 6 months ago (2015-06-11 15:54:19 UTC) #8
chunyang.dai
5 years, 6 months ago (2015-06-11 15:54:25 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2dd269f39ae6ceb5bdd040dae3a71980a1e652c2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698