Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1422)

Side by Side Diff: src/x87/debug-x87.cc

Issue 1173963002: X87: Vector ICs: debugger should save registers for vector store ics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X87 7 #if V8_TARGET_ARCH_X87
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/debug.h" 10 #include "src/debug.h"
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 RegList regs = receiver.bit() | name.bit() | slot.bit(); 186 RegList regs = receiver.bit() | name.bit() | slot.bit();
187 Generate_DebugBreakCallHelper(masm, regs, 0, false); 187 Generate_DebugBreakCallHelper(masm, regs, 0, false);
188 } 188 }
189 189
190 190
191 void DebugCodegen::GenerateStoreICDebugBreak(MacroAssembler* masm) { 191 void DebugCodegen::GenerateStoreICDebugBreak(MacroAssembler* masm) {
192 // Register state for IC store call (from ic-x87.cc). 192 // Register state for IC store call (from ic-x87.cc).
193 Register receiver = StoreDescriptor::ReceiverRegister(); 193 Register receiver = StoreDescriptor::ReceiverRegister();
194 Register name = StoreDescriptor::NameRegister(); 194 Register name = StoreDescriptor::NameRegister();
195 Register value = StoreDescriptor::ValueRegister(); 195 Register value = StoreDescriptor::ValueRegister();
196 Generate_DebugBreakCallHelper( 196 RegList regs = receiver.bit() | name.bit() | value.bit();
197 masm, receiver.bit() | name.bit() | value.bit(), 0, false); 197 if (FLAG_vector_stores) {
198 regs |= VectorStoreICDescriptor::SlotRegister().bit();
199 }
200 Generate_DebugBreakCallHelper(masm, regs, 0, false);
198 } 201 }
199 202
200 203
201 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) { 204 void DebugCodegen::GenerateKeyedLoadICDebugBreak(MacroAssembler* masm) {
202 // Register state for keyed IC load call (from ic-x87.cc). 205 // Register state for keyed IC load call (from ic-x87.cc).
203 GenerateLoadICDebugBreak(masm); 206 GenerateLoadICDebugBreak(masm);
204 } 207 }
205 208
206 209
207 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) { 210 void DebugCodegen::GenerateKeyedStoreICDebugBreak(MacroAssembler* masm) {
208 // Register state for keyed IC store call (from ic-x87.cc). 211 // Register state for keyed IC store call (from ic-x87.cc).
209 Register receiver = StoreDescriptor::ReceiverRegister(); 212 GenerateStoreICDebugBreak(masm);
210 Register name = StoreDescriptor::NameRegister();
211 Register value = StoreDescriptor::ValueRegister();
212 Generate_DebugBreakCallHelper(
213 masm, receiver.bit() | name.bit() | value.bit(), 0, false);
214 } 213 }
215 214
216 215
217 void DebugCodegen::GenerateCompareNilICDebugBreak(MacroAssembler* masm) { 216 void DebugCodegen::GenerateCompareNilICDebugBreak(MacroAssembler* masm) {
218 // Register state for CompareNil IC 217 // Register state for CompareNil IC
219 // ----------- S t a t e ------------- 218 // ----------- S t a t e -------------
220 // -- eax : value 219 // -- eax : value
221 // ----------------------------------- 220 // -----------------------------------
222 Generate_DebugBreakCallHelper(masm, eax.bit(), 0, false); 221 Generate_DebugBreakCallHelper(masm, eax.bit(), 0, false);
223 } 222 }
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
320 319
321 320
322 const bool LiveEdit::kFrameDropperSupported = true; 321 const bool LiveEdit::kFrameDropperSupported = true;
323 322
324 #undef __ 323 #undef __
325 324
326 } // namespace internal 325 } // namespace internal
327 } // namespace v8 326 } // namespace v8
328 327
329 #endif // V8_TARGET_ARCH_X87 328 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698