Issue 1173643002: Revert "Use R0/R1 instead of R4/R5 for ARM eh_return return values"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1173643002: Revert "Use R0/R1 instead of R4/R5 for ARM eh_return return values" (Closed)

Created:
5 years, 6 months ago by Derek Schuff

Modified:
5 years, 6 months ago

Reviewers:
jvoung (off chromium)

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-llvm.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Use R0/R1 instead of R4/R5 for ARM eh_return return values" This reverts commit 43d482ad1c96633d1bfb5ed7d1e50c97928ea8fa. It doesn't work correctly. It probably makes more sense to switch to EABI unwinding than put too much more effort into debugging this. TBR=jvoung@chromium.org BUG= https://code.google.com/p/nativeclient/issues/detail?id=4171 Committed: https://chromium.googlesource.com/native_client/pnacl-llvm/+/25718c289cd493879c16044c4d27522086790765

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -81 lines)			Patch
M	lib/Target/ARM/ARMBaseRegisterInfo.cpp	View	2 chunks	+1 line, -9 lines	0 comments	Download
M	lib/Target/ARM/ARMCallingConv.td	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/Target/ARM/ARMFrameLowering.cpp	View	4 chunks	+0 lines, -38 lines	0 comments	Download
M	lib/Target/ARM/ARMISelLowering.cpp	View	1 chunk	+15 lines, -8 lines	0 comments	Download
D	test/CodeGen/ARM/ehreturn.ll	View	1 chunk	+0 lines, -25 lines	0 comments	Download

Total messages: 4 (1 generated)

Derek Schuff

Committed patchset #1 (id:1) manually as 25718c289cd493879c16044c4d27522086790765 (presubmit successful).

5 years, 6 months ago (2015-06-09 16:17:21 UTC) #3

Message was sent while issue was closed.

lgtm