Coverity: Remove default TabCaptureRequest constructor.

chrome/browser/extensions/api/tab_capture/tab_capture_registry.h

Index: chrome/browser/extensions/api/tab_capture/tab_capture_registry.h
diff --git a/chrome/browser/extensions/api/tab_capture/tab_capture_registry.h b/chrome/browser/extensions/api/tab_capture/tab_capture_registry.h
index 3455bedf8e16267ec057837b651e0d53be1423ef..e904d2b364dae37a04da25c2174783bab477c7d6 100644
--- a/chrome/browser/extensions/api/tab_capture/tab_capture_registry.h
+++ b/chrome/browser/extensions/api/tab_capture/tab_capture_registry.h
@@ -34,7 +34,6 @@ class TabCaptureRegistry : public ProfileKeyedService,
     int tab_id;
     tab_capture::TabCaptureState status;
 
-    TabCaptureRequest() : tab_id(-1) {}

[Matt Perry, 2013/01/04 21:17:18]

What is the reason for removing this constructor? Maybe it's that status is not
being initialized?

There should be nothing wrong with a default constructor. It certainly makes the
code much easier to read.

[justinlin, 2013/01/04 22:10:52]

Yea, kmadhusu@ found the uninitialized status issue. I think it's better to just
remove it since I don't expect we should be using the default constructor (and
having a request with an empty extension id) and to avoid accidental uses.

     TabCaptureRequest(std::string extension_id, int tab_id,
                       tab_capture::TabCaptureState status)
         : extension_id(extension_id), tab_id(tab_id), status(status) {}

[Matt Perry, 2013/01/04 21:17:18]

Move the constructor definition to the .cc file. Also, add a destructor with an
(empty) definition in the .cc. See
http://dev.chromium.org/developers/coding-style#TOC-Inline-functions for why.

[justinlin, 2013/01/04 22:10:52]

Done.