Coverity: Remove default TabCaptureRequest constructor.

chrome/browser/extensions/api/tab_capture/tab_capture_registry.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_TAB_CAPTURE_TAB_CAPTURE_REGISTRY_H_
 #define CHROME_BROWSER_EXTENSIONS_API_TAB_CAPTURE_TAB_CAPTURE_REGISTRY_H_
 
 #include <map>
 #include <string>
 #include <utility>
@@ skipping 16 matching lines @@
 namespace tab_capture = extensions::api::tab_capture;
 
 class TabCaptureRegistry : public ProfileKeyedService,
                            public content::NotificationObserver {
  public:
   struct TabCaptureRequest {
     std::string extension_id;
     int tab_id;
     tab_capture::TabCaptureState status;
 
-    TabCaptureRequest() : tab_id(-1) {}

[Matt Perry, 2013/01/04 21:17:18]

What is the reason for removing this constructor? Maybe it's that status is not
being initialized?

There should be nothing wrong with a default constructor. It certainly makes the
code much easier to read.

[justinlin, 2013/01/04 22:10:52]

Yea, kmadhusu@ found the uninitialized status issue. I think it's better to just
remove it since I don't expect we should be using the default constructor (and
having a request with an empty extension id) and to avoid accidental uses.

     TabCaptureRequest(std::string extension_id, int tab_id,
                       tab_capture::TabCaptureState status)
         : extension_id(extension_id), tab_id(tab_id), status(status) {}

[Matt Perry, 2013/01/04 21:17:18]

Move the constructor definition to the .cc file. Also, add a destructor with an
(empty) definition in the .cc. See
http://dev.chromium.org/developers/coding-style#TOC-Inline-functions for why.

[justinlin, 2013/01/04 22:10:52]

Done.

   };
   typedef std::vector<TabCaptureRequest> CaptureRequestList;
 
   explicit TabCaptureRegistry(Profile* profile);
 
   const CaptureRequestList GetCapturedTabs(const std::string& extension_id);
   bool AddRequest(const std::pair<int, int>, const TabCaptureRequest& request);
   bool VerifyRequest(int render_process_id, int render_view_id);
 
  private:
@@ skipping 48 matching lines @@
   content::NotificationRegistrar registrar_;
   Profile* const profile_;
   DeviceCaptureRequestMap requests_;
 
   DISALLOW_COPY_AND_ASSIGN(TabCaptureRegistry);
 };
 
 }  // namespace extension
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_TAB_CAPTURE_TAB_CAPTURE_REGISTRY_H_