Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/compiler/lib/src/ssa/optimize.dart

Issue 1173403002: dart2js: Fix hints in code base. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Updated to latest revision Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/compiler/lib/src/source_file_provider.dart ('K') | « pkg/compiler/lib/src/ssa/codegen.dart ('k') | pkg/compiler/lib/src/ssa/ssa.dart » ('j') | pkg/compiler/lib/src/use_unused_api.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/optimize.dart
diff --git a/pkg/compiler/lib/src/ssa/optimize.dart b/pkg/compiler/lib/src/ssa/optimize.dart
index 3c2e5e6fbd72838b54bdb2e46512b9488f7f1edc..adb39b9eda65b45f30a9bbc0289eb6d866fc450f 100644
--- a/pkg/compiler/lib/src/ssa/optimize.dart
+++ b/pkg/compiler/lib/src/ssa/optimize.dart
@@ -426,8 +426,7 @@ class SsaInstructionSimplifier extends HBaseVisitor
int inputPosition = 1; // Skip receiver.
bool canInline = true;
signature.forEachParameter((ParameterElement element) {
- if (inputPosition < inputs.length && canInline) {
- HInstruction input = inputs[inputPosition++];
+ if (inputPosition++ < inputs.length && canInline) {
DartType type = element.type.unalias(compiler);
if (type is FunctionType) {
canInline = false;
@@ -697,7 +696,6 @@ class SsaInstructionSimplifier extends HBaseVisitor
}
HInstruction visitTypeConversion(HTypeConversion node) {
- HInstruction value = node.inputs[0];
DartType type = node.typeExpression;
if (type != null) {
if (type.isMalformed) {
« pkg/compiler/lib/src/source_file_provider.dart ('K') | « pkg/compiler/lib/src/ssa/codegen.dart ('k') | pkg/compiler/lib/src/ssa/ssa.dart » ('j') | pkg/compiler/lib/src/use_unused_api.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698