Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1173333004: Add script context with context-allocated "const this" (Closed)

Created:
5 years, 6 months ago by wingo
Modified:
5 years, 6 months ago
CC:
v8-dev, Yang, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add script context with context-allocated "const this" This is a reapplication of https://codereview.chromium.org/1179893002/. R=rossberg@chromium.org,mstarzinger@chromium.org LOG=N BUG=498811 Committed: https://crrev.com/cfc764f4050edc74aef92daa4c39ccc113893968 Cr-Commit-Position: refs/heads/master@{#28994}

Patch Set 1 #

Patch Set 2 : Fix gcmole error in bootstrapper.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -204 lines) Patch
M src/arm/full-codegen-arm.cc View 6 chunks +14 lines, -22 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 5 chunks +13 lines, -18 lines 0 comments Download
M src/bootstrapper.cc View 1 4 chunks +42 lines, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 3 chunks +11 lines, -28 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 6 chunks +10 lines, -14 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 5 chunks +14 lines, -22 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 6 chunks +13 lines, -21 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 6 chunks +14 lines, -21 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 4 chunks +14 lines, -15 lines 0 comments Download
M src/scopeinfo.cc View 2 chunks +72 lines, -0 lines 0 comments Download
M src/scopes.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/snapshot/snapshot-common.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/variables.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 6 chunks +9 lines, -15 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 6 chunks +10 lines, -14 lines 0 comments Download
M test/unittests/compiler/js-type-feedback-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
rossberg
What has changed?
5 years, 6 months ago (2015-06-12 10:40:16 UTC) #1
wingo
On 2015/06/12 10:40:16, rossberg wrote: > What has changed? Patchset 1 is the original patchset. ...
5 years, 6 months ago (2015-06-12 10:46:57 UTC) #2
Michael Starzinger
LGTM on patch set #2.
5 years, 6 months ago (2015-06-12 10:48:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173333004/20001
5 years, 6 months ago (2015-06-12 10:49:25 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-12 11:11:18 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/cfc764f4050edc74aef92daa4c39ccc113893968 Cr-Commit-Position: refs/heads/master@{#28994}
5 years, 6 months ago (2015-06-12 11:11:38 UTC) #7
wingo
5 years, 6 months ago (2015-06-12 11:52:42 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1177903004/ by wingo@igalia.com.

The reason for reverting is: nosnap failure.

Powered by Google App Engine
This is Rietveld 408576698