sky/sdk/lib/widgets/fixed_height_scrollable.dart - Issue 1173293005: Make UINode's key a String

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/widgets/fixed_height_scrollable.dart

Issue 1173293005: Make UINode's key a String (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: nit Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/sdk/lib/widgets/fixed_height_scrollable.dart

diff --git a/sky/sdk/lib/widgets/fixed_height_scrollable.dart b/sky/sdk/lib/widgets/fixed_height_scrollable.dart

index 3336427d2b7dc61a648a3caa53a7b7ec68503012..8d12205173308a6bd2b6e35e782eb7d3e585534f 100644

--- a/sky/sdk/lib/widgets/fixed_height_scrollable.dart

+++ b/sky/sdk/lib/widgets/fixed_height_scrollable.dart

@@ -12,7 +12,7 @@ import 'scrollable.dart';

abstract class FixedHeightScrollable extends Scrollable {

- FixedHeightScrollable({ this.itemHeight, Color backgroundColor, Object key })

+ FixedHeightScrollable({ String key, this.itemHeight, Color backgroundColor })

: super(key: key, backgroundColor: backgroundColor) {

assert(itemHeight != null);

}