Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1173293005: Make UINode's key a String (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make UINode's key a String We need the key to be a String even though we claimed we could support any Object. Also, clean up some style nits including shortening the |root| getters on OneChildRenderNodeWrappers. Fixes https://github.com/domokit/sky_sdk/issues/26. TBR=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/a7b014712d91f464c30a8492c34153944fe154d3

Patch Set 1 #

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -134 lines) Patch
M sky/examples/stocks2/lib/stock_arrow.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/stocks2/lib/stock_list.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/stocks2/lib/stock_menu.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/widgets/spinning_mixed.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/editing2/editable_text.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/editing2/input.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/animated_component.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/basic.dart View 14 chunks +60 lines, -64 lines 0 comments Download
M sky/sdk/lib/widgets/button_base.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/checkbox.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/drawer.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/drawer_header.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/fixed_height_scrollable.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/floating_action_button.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sky/sdk/lib/widgets/ink_well.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M sky/sdk/lib/widgets/material.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/menu_divider.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/menu_item.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sky/sdk/lib/widgets/modal_overlay.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/popup_menu.dart View 2 chunks +5 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/popup_menu_item.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/radio.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/raised_button.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/scaffold.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/scrollable.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sky/sdk/lib/widgets/switch.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/toggleable.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/widgets/ui_node.dart View 1 8 chunks +26 lines, -38 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-06-16 04:30:41 UTC) #1
abarth-chromium
Committed patchset #2 (id:20001) manually as a7b014712d91f464c30a8492c34153944fe154d3 (presubmit successful).
5 years, 6 months ago (2015-06-16 04:39:14 UTC) #2
Hixie
5 years, 6 months ago (2015-06-16 16:16:09 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698