Issue 1173283004: Restore ExecutableAccessorInfoHandling for now

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1173283004: Restore ExecutableAccessorInfoHandling for now (Closed)

Created:
5 years, 6 months ago by Toon Verwaest

Modified:
5 years, 6 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Restore ExecutableAccessorInfoHandling for now BUG=v8:4137 LOG=n R=ishell@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/91de3758682dafc81ec88e4d27497171954734fc

Patch Set 3 : #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -27 lines)			Patch
M	src/api.cc	View	1	2 chunks	+7 lines, -5 lines	1 comment	Download
M	src/objects.h	View		1 chunk	+10 lines, -3 lines	0 comments	Download
M	src/objects.cc	View	1 2	6 chunks	+8 lines, -6 lines	0 comments	Download
M	src/runtime/runtime.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/runtime/runtime-object.cc	View	1 2	3 chunks	+9 lines, -8 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 2	1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Igor Sheludko

https://codereview.chromium.org/1173283004/diff/40001/src/api.cc File src/api.cc (right): https://codereview.chromium.org/1173283004/diff/40001/src/api.cc#newcode3580 src/api.cc:3580: i::JSObject::DONT_FORCE_FIELD).is_null(); Probably you should pass DEFAULT_HANDLING here.

5 years, 6 months ago (2015-06-11 20:10:01 UTC) #3

Toon Verwaest

5 years, 6 months ago (2015-06-11 20:15:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
91de3758682dafc81ec88e4d27497171954734fc (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1173283004: Restore ExecutableAccessorInfoHandling for now (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages