Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: src/api.cc

Issue 1173283004: Restore ExecutableAccessorInfoHandling for now (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index b8812800081d1b36ea84b5871c2a80a8d870bb93..c405b875385e4e1ad8235d6148b97f66f2bd7ac2 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -3535,8 +3535,9 @@ Maybe<bool> v8::Object::CreateDataProperty(v8::Local<v8::Context> context,
if (it.IsFound() && !it.IsConfigurable()) return Just(false);
- has_pending_exception = i::Runtime::DefineObjectProperty(
- self, key_obj, value_obj, NONE).is_null();
+ has_pending_exception =
+ i::Runtime::DefineObjectProperty(self, key_obj, value_obj, NONE,
+ i::JSObject::DONT_FORCE_FIELD).is_null();
RETURN_ON_FAILED_EXECUTION_PRIMITIVE(bool);
return Just(true);
}
@@ -3573,9 +3574,10 @@ Maybe<bool> v8::Object::CreateDataProperty(v8::Local<v8::Context> context,
return Just(false);
}
- has_pending_exception = i::Runtime::DefineObjectProperty(
- self, isolate->factory()->Uint32ToString(index),
- value_obj, NONE).is_null();
+ has_pending_exception =
+ i::Runtime::DefineObjectProperty(
+ self, isolate->factory()->Uint32ToString(index), value_obj, NONE,
+ i::JSObject::DONT_FORCE_FIELD).is_null();
Igor Sheludko 2015/06/11 20:10:01 Probably you should pass DEFAULT_HANDLING here.
RETURN_ON_FAILED_EXECUTION_PRIMITIVE(bool);
return Just(true);
}
« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698