components/tracing/tracing_messages.h - Issue 1173263004: [tracing] Send unique tracing process id for cross-process memory dumps identification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/tracing_messages.h

Issue 1173263004: [tracing] Send unique tracing process id for cross-process memory dumps identification. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/trace_event/memory_allocator_dump_guid.cc ('K') | « components/tracing/child_trace_message_filter.cc ('k') | content/browser/browser_child_process_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/tracing/tracing_messages.h

diff --git a/components/tracing/tracing_messages.h b/components/tracing/tracing_messages.h

index 14f31bb1079fb8ee27d62d86f2422b83f2e738ed..6851d9089bac36eef96a48a1f95816ac3a37e4e0 100644

--- a/components/tracing/tracing_messages.h

+++ b/components/tracing/tracing_messages.h

@@ -32,9 +32,10 @@ IPC_ENUM_TRAITS_MAX_VALUE(

static_cast<int>(base::trace_event::MemoryDumpType::LAST))

// Sent to all child processes to enable trace event recording.

-IPC_MESSAGE_CONTROL2(TracingMsg_BeginTracing,

+IPC_MESSAGE_CONTROL3(TracingMsg_BeginTracing,

std::string /* trace_config_str */,

- base::TraceTicks /* browser_time */)

+ base::TraceTicks /* browser_time */,

+ int /* Unique child process id */)

picksi 2015/06/16 16:18:37 Is Process ID really an int? Is it not a uint or s

ssid 2015/06/19 10:18:15 It is created as int by the existing code.

// Sent to all child processes to disable trace event recording.

IPC_MESSAGE_CONTROL0(TracingMsg_EndTracing)