Chromium Code Reviews Chromium Code Reviews
Issue 1173263004:
[tracing] Send unique tracing process id for cross-process memory dumps identification. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 // Multiply-included message header, no traditional include guard. | 5 // Multiply-included message header, no traditional include guard. |
| 6 #include <string> | 6 #include <string> |
| 7 #include <vector> | 7 #include <vector> |
| 8 | 8 |
| 9 #include "base/basictypes.h" | 9 #include "base/basictypes.h" |
| 10 #include "base/sync_socket.h" | 10 #include "base/sync_socket.h" |
| (...skipping 14 matching lines...) Expand all Loading... | |
| 25 IPC_STRUCT_TRAITS_BEGIN(base::trace_event::MemoryDumpRequestArgs) | 25 IPC_STRUCT_TRAITS_BEGIN(base::trace_event::MemoryDumpRequestArgs) |
| 26 IPC_STRUCT_TRAITS_MEMBER(dump_guid) | 26 IPC_STRUCT_TRAITS_MEMBER(dump_guid) |
| 27 IPC_STRUCT_TRAITS_MEMBER(dump_type) | 27 IPC_STRUCT_TRAITS_MEMBER(dump_type) |
| 28 IPC_STRUCT_TRAITS_END() | 28 IPC_STRUCT_TRAITS_END() |
| 29 | 29 |
| 30 IPC_ENUM_TRAITS_MAX_VALUE( | 30 IPC_ENUM_TRAITS_MAX_VALUE( |
| 31 base::trace_event::MemoryDumpType, | 31 base::trace_event::MemoryDumpType, |
| 32 static_cast<int>(base::trace_event::MemoryDumpType::LAST)) | 32 static_cast<int>(base::trace_event::MemoryDumpType::LAST)) |
| 33 | 33 |
| 34 // Sent to all child processes to enable trace event recording. | 34 // Sent to all child processes to enable trace event recording. |
| 35 IPC_MESSAGE_CONTROL2(TracingMsg_BeginTracing, | 35 IPC_MESSAGE_CONTROL3(TracingMsg_BeginTracing, |
| 36 std::string /* trace_config_str */, | 36 std::string /* trace_config_str */, |
| 37 base::TraceTicks /* browser_time */) | 37 base::TraceTicks /* browser_time */, |
| 38 int /* Unique child process id */) | |
|
picksi
2015/06/16 16:18:37
Is Process ID really an int? Is it not a uint or s
ssid
2015/06/19 10:18:15
It is created as int by the existing code.
| |
| 38 | 39 |
| 39 // Sent to all child processes to disable trace event recording. | 40 // Sent to all child processes to disable trace event recording. |
| 40 IPC_MESSAGE_CONTROL0(TracingMsg_EndTracing) | 41 IPC_MESSAGE_CONTROL0(TracingMsg_EndTracing) |
| 41 | 42 |
| 42 // Sent to all child processes to start monitoring. | 43 // Sent to all child processes to start monitoring. |
| 43 IPC_MESSAGE_CONTROL2(TracingMsg_EnableMonitoring, | 44 IPC_MESSAGE_CONTROL2(TracingMsg_EnableMonitoring, |
| 44 std::string /* trace_config_str */, | 45 std::string /* trace_config_str */, |
| 45 base::TraceTicks /* browser_time */) | 46 base::TraceTicks /* browser_time */) |
| 46 | 47 |
| 47 // Sent to all child processes to stop monitoring. | 48 // Sent to all child processes to stop monitoring. |
| (...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 99 base::trace_event::TraceLogStatus /*status of the trace log*/) | 100 base::trace_event::TraceLogStatus /*status of the trace log*/) |
| 100 | 101 |
| 101 // Sent to the browser to initiate a global memory dump from a child process. | 102 // Sent to the browser to initiate a global memory dump from a child process. |
| 102 IPC_MESSAGE_CONTROL1(TracingHostMsg_GlobalMemoryDumpRequest, | 103 IPC_MESSAGE_CONTROL1(TracingHostMsg_GlobalMemoryDumpRequest, |
| 103 base::trace_event::MemoryDumpRequestArgs) | 104 base::trace_event::MemoryDumpRequestArgs) |
| 104 | 105 |
| 105 // Reply to TracingMsg_ProcessMemoryDumpRequest. | 106 // Reply to TracingMsg_ProcessMemoryDumpRequest. |
| 106 IPC_MESSAGE_CONTROL2(TracingHostMsg_ProcessMemoryDumpResponse, | 107 IPC_MESSAGE_CONTROL2(TracingHostMsg_ProcessMemoryDumpResponse, |
| 107 uint64 /* dump_guid */, | 108 uint64 /* dump_guid */, |
| 108 bool /* success */) | 109 bool /* success */) |
| OLD | NEW |
