Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1173083004: Revert of Make sure multi chracter codepoints are deleted correctly (Closed)

Created:
5 years, 6 months ago by David Trainor- moved to gerrit
Modified:
5 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make sure multi chracter codepoints are deleted correctly (patchset #6 id:100001 of https://codereview.chromium.org/1165793007/) Reason for revert: Failing Android Tests (dbg) builder: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/28499 The newly added test seems to be flaky. Original issue's description: > Make sure multi chracter codepoints are deleted correctly > > deleteSurroundingText() only deletes one character even for multi-character > codepoint. > > On the blink side, we have InputMethodController::extendSelectionAndDelete() > to make sure selection and deletion respect Unicode boundaries. However, > AdapterInputConnection keeps track of selection region separately, and this > value is incorrectly updated. > > On top of adding a new test for this case, it extends > waitAndVerifyEditorCallback to also check the outbound calls to > InputMethodManager. > > The above extension found that testEnterKeyEventWhileComposingText fails > because there is hidden discrepancy between blink implementation and > what we report to InputMethodManager. So I've added a TODO for that. > > BUG=497091 > > Committed: https://crrev.com/5f6e036312bc4a978768f5b5971eee1a5ec9f272 > Cr-Commit-Position: refs/heads/master@{#333704} TBR=aelias@chromium.org,aurimas@chromium.org,bcwhite@chromium.org,tedchoc@chromium.org,changwan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=497091 Committed: https://crrev.com/bac56ba37b1b83cc0a40e9d1b4993ab811149ea8 Cr-Commit-Position: refs/heads/master@{#333765}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -238 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java View 5 chunks +6 lines, -31 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java View 2 chunks +0 lines, -18 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 28 chunks +69 lines, -129 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestInputMethodManagerWrapper.java View 3 chunks +1 line, -60 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
David Trainor- moved to gerrit
Created Revert of Make sure multi chracter codepoints are deleted correctly
5 years, 6 months ago (2015-06-10 18:28:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1173083004/1
5 years, 6 months ago (2015-06-10 18:29:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 18:30:39 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 18:31:37 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bac56ba37b1b83cc0a40e9d1b4993ab811149ea8
Cr-Commit-Position: refs/heads/master@{#333765}

Powered by Google App Engine
This is Rietveld 408576698