Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java

Issue 1173083004: Revert of Make sure multi chracter codepoints are deleted correctly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java b/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java
index 9adf69292ab3f7c588a6681aeb1431e7ece67b0d..2e088a354059e624770c343e77546e5bb111711a 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java
@@ -9,6 +9,7 @@
import android.text.InputType;
import android.text.Selection;
import android.text.TextUtils;
+import android.util.Log;
import android.view.KeyCharacterMap;
import android.view.KeyEvent;
import android.view.View;
@@ -17,7 +18,6 @@
import android.view.inputmethod.ExtractedText;
import android.view.inputmethod.ExtractedTextRequest;
-import org.chromium.base.Log;
import org.chromium.base.VisibleForTesting;
import org.chromium.blink_public.web.WebInputEventType;
import org.chromium.blink_public.web.WebTextInputFlags;
@@ -229,8 +229,8 @@
}
// updateSelection should be called every time the selection or composition changes
// if it happens not within a batch edit, or at the end of each top level batch edit.
- getInputMethodManagerWrapper().updateSelection(
- mInternalView, selectionStart, selectionEnd, compositionStart, compositionEnd);
+ getInputMethodManagerWrapper().updateSelection(mInternalView,
+ selectionStart, selectionEnd, compositionStart, compositionEnd);
mLastUpdateSelectionStart = selectionStart;
mLastUpdateSelectionEnd = selectionEnd;
mLastUpdateCompositionStart = compositionStart;
@@ -350,23 +350,10 @@
return deleteSurroundingTextImpl(beforeLength, afterLength, false);
}
- /**
- * Check if the given {@code index} is between UTF-16 surrogate pair.
- * @param str The String.
- * @param index The index
- * @return True if the index is between UTF-16 surrogate pair, false otherwise.
- */
- @VisibleForTesting
- static boolean isIndexBetweenUtf16SurrogatePair(CharSequence str, int index) {
- return index > 0 && index < str.length() && Character.isHighSurrogate(str.charAt(index - 1))
- && Character.isLowSurrogate(str.charAt(index));
- }
-
private boolean deleteSurroundingTextImpl(
int beforeLength, int afterLength, boolean fromPhysicalKey) {
if (DEBUG) {
- Log.w(TAG, "deleteSurroundingText [" + beforeLength + " " + afterLength + " "
- + fromPhysicalKey + "]");
+ Log.w(TAG, "deleteSurroundingText [" + beforeLength + " " + afterLength + "]");
}
if (mPendingAccent != 0) {
@@ -375,22 +362,10 @@
int originalBeforeLength = beforeLength;
int originalAfterLength = afterLength;
- int selectionStart = Selection.getSelectionStart(mEditable);
- int selectionEnd = Selection.getSelectionEnd(mEditable);
- int availableBefore = selectionStart;
- int availableAfter = mEditable.length() - selectionEnd;
+ int availableBefore = Selection.getSelectionStart(mEditable);
+ int availableAfter = mEditable.length() - Selection.getSelectionEnd(mEditable);
beforeLength = Math.min(beforeLength, availableBefore);
afterLength = Math.min(afterLength, availableAfter);
-
- // Adjust these values even before calling super.deleteSurroundingText() to be consistent
- // with the super class.
- if (isIndexBetweenUtf16SurrogatePair(mEditable, selectionStart - beforeLength)) {
- beforeLength += 1;
- }
- if (isIndexBetweenUtf16SurrogatePair(mEditable, selectionEnd + afterLength)) {
- afterLength += 1;
- }
-
super.deleteSurroundingText(beforeLength, afterLength);
updateSelectionIfRequired();
« no previous file with comments | « no previous file | content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698