Source/core/frame/FrameView.h - Issue 1173053003: Remove ScrollableArea::notifyScrollPositionChanged and cleanup scroll animators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/FrameView.h

Issue 1173053003: Remove ScrollableArea::notifyScrollPositionChanged and cleanup scroll animators. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase + remove updateScrollbars from FrameView::setScrollPosition Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/FrameView.h

diff --git a/Source/core/frame/FrameView.h b/Source/core/frame/FrameView.h

index 754075a5e76f3aa9ea74055ab53055a9199db551..4306fb4134adc820af063b5abdc29b1a93f6b022 100644

--- a/Source/core/frame/FrameView.h

+++ b/Source/core/frame/FrameView.h

@@ -696,9 +696,6 @@ private:

bool adjustScrollbarExistence(ComputeScrollbarExistenceOption = FirstPass);

void adjustScrollbarOpacity();

- // FIXME(bokan): setScrollOffset, setScrollPosition, scrollTo, scrollToOffsetWithoutAnimation,

- // notifyScrollPositionChanged...there's too many ways to scroll this class. This needs

- // some cleanup.

void setScrollOffsetFromUpdateScrollbars(const DoubleSize&);

IntRect rectToCopyOnScroll() const;

« no previous file with comments | « no previous file | Source/core/frame/FrameView.cpp » ('j') | no next file with comments »