Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Side by Side Diff: Source/core/frame/FrameView.h

Issue 1173053003: Remove ScrollableArea::notifyScrollPositionChanged and cleanup scroll animators. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase + remove updateScrollbars from FrameView::setScrollPosition Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 (C) 1998 Waldo Bastian (bastian@kde.org) 3 (C) 1998 Waldo Bastian (bastian@kde.org)
4 (C) 1998, 1999 Torben Weis (weis@kde.org) 4 (C) 1998, 1999 Torben Weis (weis@kde.org)
5 (C) 1999 Lars Knoll (knoll@kde.org) 5 (C) 1999 Lars Knoll (knoll@kde.org)
6 (C) 1999 Antti Koivisto (koivisto@kde.org) 6 (C) 1999 Antti Koivisto (koivisto@kde.org)
7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 7 Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
8 8
9 This library is free software; you can redistribute it and/or 9 This library is free software; you can redistribute it and/or
10 modify it under the terms of the GNU Library General Public 10 modify it under the terms of the GNU Library General Public
(...skipping 678 matching lines...) Expand 10 before | Expand all | Expand 10 after
689 689
690 void updateScrollCorner(); 690 void updateScrollCorner();
691 691
692 AXObjectCache* axObjectCache() const; 692 AXObjectCache* axObjectCache() const;
693 void removeFromAXObjectCache(); 693 void removeFromAXObjectCache();
694 694
695 void setLayoutSizeInternal(const IntSize&); 695 void setLayoutSizeInternal(const IntSize&);
696 696
697 bool adjustScrollbarExistence(ComputeScrollbarExistenceOption = FirstPass); 697 bool adjustScrollbarExistence(ComputeScrollbarExistenceOption = FirstPass);
698 void adjustScrollbarOpacity(); 698 void adjustScrollbarOpacity();
699 // FIXME(bokan): setScrollOffset, setScrollPosition, scrollTo, scrollToOffse tWithoutAnimation,
700 // notifyScrollPositionChanged...there's too many ways to scroll this class. This needs
701 // some cleanup.
702 void setScrollOffsetFromUpdateScrollbars(const DoubleSize&); 699 void setScrollOffsetFromUpdateScrollbars(const DoubleSize&);
703 700
704 IntRect rectToCopyOnScroll() const; 701 IntRect rectToCopyOnScroll() const;
705 702
706 bool isFrameViewScrollbar(const Widget* child) const { return horizontalScro llbar() == child || verticalScrollbar() == child; } 703 bool isFrameViewScrollbar(const Widget* child) const { return horizontalScro llbar() == child || verticalScrollbar() == child; }
707 704
708 ScrollingCoordinator* scrollingCoordinator(); 705 ScrollingCoordinator* scrollingCoordinator();
709 706
710 void prepareLayoutAnalyzer(); 707 void prepareLayoutAnalyzer();
711 PassRefPtr<TracedValue> analyzerCounters(); 708 PassRefPtr<TracedValue> analyzerCounters();
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
877 static const unsigned visualPixelThreshold = 32 * 32; 874 static const unsigned visualPixelThreshold = 32 * 32;
878 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold) 875 if (m_visuallyNonEmptyPixelCount > visualPixelThreshold)
879 setIsVisuallyNonEmpty(); 876 setIsVisuallyNonEmpty();
880 } 877 }
881 878
882 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView()); 879 DEFINE_TYPE_CASTS(FrameView, Widget, widget, widget->isFrameView(), widget.isFra meView());
883 880
884 } // namespace blink 881 } // namespace blink
885 882
886 #endif // FrameView_h 883 #endif // FrameView_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698