Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1172753003: Move LowerCaseEqualsASCII to base namespace (Closed)

Created:
5 years, 6 months ago by brettw
Modified:
5 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, asanka, yusukes+watch_chromium.org, posciak+watch_chromium.org, nektar+watch_chromium.org, vabr+watchlist_chromium.org, nasko+codewatch_chromium.org, browser-components-watch_chromium.org, jdduke+watch_chromium.org, dmazzoni+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, Matt Giuca, benjhayden+dwatch_chromium.org, grt+watch_chromium.org, samuong+watch_chromium.org, dzhioev+watch_chromium.org, jam, nona+watch_chromium.org, je_julie, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, tdresser+watch_chromium.org, erikwright+watch_chromium.org, ozone-reviews_chromium.org, mlamouri+watch-content_chromium.org, gavinp+disk_chromium.org, creis+watch_chromium.org, derat+watch_chromium.org, tapted, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, oshima+watch_chromium.org, kalyank, piman+watch_chromium.org, gcasto+watchlist_chromium.org, mlamouri+watch-manifest_chromium.org, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org, plundblad+watch_chromium.org, hashimoto+watch_chromium.org, tfarina, shuchen+watch_chromium.org, mcasas+watch_chromium.org, aboxhall+watch_chromium.org, davemoore+watch_chromium.org, dtseng+watch_chromium.org, wfh+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, James Su, wjia+watch_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@string_util
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move LowerCaseEqualsASCII to base namespace Remove url:: variants. Add the 4-element version from url:: to base:: Committed: https://crrev.com/bc17d2c8d864a118f48a84de0709f5a6c463cffd Cr-Commit-Position: refs/heads/master@{#333597}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+436 lines, -450 lines) Patch
M base/files/file_util_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M base/strings/string_util.h View 1 chunk +20 lines, -16 lines 0 comments Download
M base/strings/string_util.cc View 2 chunks +15 lines, -3 lines 0 comments Download
M chrome/browser/auto_launch_trial.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/events/event_rewriter.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_extensions.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/io_thread.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/memory_details.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/net/firefox_proxy_settings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/themes/browser_theme_pack.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/themes/theme_properties.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/app_list/search/common/webservice_search_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/webstore/webstore_provider.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/login/login_prompt.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/keyboard_access_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/setup/install_worker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/webstore_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/web_apps.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/chromedriver/element_util.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/utility/importer/bookmark_html_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/importer/ie_importer_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chromeos/dbus/dbus_client_bundle.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/content/browser/wallet/form_field_error.cc View 1 chunk +13 lines, -13 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_client.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_signin_helper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/renderer/password_form_conversion_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/contact_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/credit_card_field.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/state_names.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/wallet/real_pan_wallet_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_headers.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M components/google/core/browser/google_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/history/core/browser/visitsegment_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/html_viewer/blink_url_request_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/serialization/serialization_utils.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M components/omnibox/autocomplete_input.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M components/omnibox/search_provider.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/password_manager/core/browser/affiliation_utils.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M components/plugins/renderer/mobile_youtube_plugin.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/policy/core/common/policy_loader_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/search_engines/template_url_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/content/renderer/translate_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/url_fixer/url_fixer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/webcrypto/test/test_helpers.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_state_impl_win.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/child_process_security_policy_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_stats.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/loader/buffered_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/multipart_response_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/plugin_url_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/webplugin_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/site_isolation_policy.cc View 3 chunks +12 lines, -11 lines 0 comments Download
M content/child/web_url_request_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/android/address_parser.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M content/common/android/address_parser_internal.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/window_container_type.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/renderer/dom_serializer_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/fetchers/resource_fetcher_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/manifest/manifest_parser.cc View 2 chunks +16 lines, -12 lines 0 comments Download
M content/renderer/media/user_media_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/npapi/webplugin_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/savable_resources.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/net/url_request_abort_on_end_job.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/plugin/plugin_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/web_request/web_request_api_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/csp_validator.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_test_expectations_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/chrome_url_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M media/base/audio_video_metadata_extractor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/host_mapping_rules.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/net_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/filter/filter.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/http/http_auth.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/http/http_auth_gssapi_posix.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_auth_handler_basic.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_auth_handler_digest.cc View 4 chunks +16 lines, -16 lines 0 comments Download
M net/http/http_auth_handler_mock.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth_handler_ntlm.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth_sspi_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_cache_transaction.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/http/http_content_disposition.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M net/http/http_response_headers.cc View 7 chunks +10 lines, -11 lines 0 comments Download
M net/http/http_security_headers.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M net/http/http_util.cc View 9 chunks +16 lines, -14 lines 0 comments Download
M net/proxy/proxy_bypass_rules.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_script_fetcher_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_server.cc View 2 chunks +14 lines, -14 lines 0 comments Download
M net/test/url_request/url_request_slow_download_job.cc View 4 chunks +14 lines, -9 lines 0 comments Download
M net/url_request/url_request_file_job.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/url_request/url_request_job_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_basic_handshake_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M pdf/document_loader.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M ui/accessibility/ax_node_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util.cc View 3 chunks +13 lines, -13 lines 0 comments Download
M ui/base/l10n/l10n_util_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_property_provider.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M ui/gfx/render_text_harfbuzz.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M url/gurl.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M url/url_util.h View 1 chunk +0 lines, -17 lines 0 comments Download
M url/url_util.cc View 5 chunks +6 lines, -47 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
5 years, 6 months ago (2015-06-09 20:19:59 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172753003/1
5 years, 6 months ago (2015-06-09 20:22:08 UTC) #4
sky
LGTM
5 years, 6 months ago (2015-06-09 20:50:43 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-09 22:09:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1172753003/1
5 years, 6 months ago (2015-06-09 22:13:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-09 22:39:22 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 22:40:09 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bc17d2c8d864a118f48a84de0709f5a6c463cffd
Cr-Commit-Position: refs/heads/master@{#333597}

Powered by Google App Engine
This is Rietveld 408576698