Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Side by Side Diff: net/http/http_auth_handler_basic.cc

Issue 1172753003: Move LowerCaseEqualsASCII to base namespace (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@string_util
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/http/http_auth_gssapi_posix.cc ('k') | net/http/http_auth_handler_digest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/http/http_auth_handler_basic.h" 5 #include "net/http/http_auth_handler_basic.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/base64.h" 9 #include "base/base64.h"
10 #include "base/strings/string_util.h" 10 #include "base/strings/string_util.h"
(...skipping 22 matching lines...) Expand all
33 // The over-the-wire realm is encoded as ISO-8859-1 (aka Latin-1). 33 // The over-the-wire realm is encoded as ISO-8859-1 (aka Latin-1).
34 // 34 //
35 // TODO(cbentzel): Realm may need to be decoded using RFC 2047 rules as 35 // TODO(cbentzel): Realm may need to be decoded using RFC 2047 rules as
36 // well, see http://crbug.com/25790. 36 // well, see http://crbug.com/25790.
37 bool ParseRealm(const HttpAuthChallengeTokenizer& tokenizer, 37 bool ParseRealm(const HttpAuthChallengeTokenizer& tokenizer,
38 std::string* realm) { 38 std::string* realm) {
39 CHECK(realm); 39 CHECK(realm);
40 realm->clear(); 40 realm->clear();
41 HttpUtil::NameValuePairsIterator parameters = tokenizer.param_pairs(); 41 HttpUtil::NameValuePairsIterator parameters = tokenizer.param_pairs();
42 while (parameters.GetNext()) { 42 while (parameters.GetNext()) {
43 if (!LowerCaseEqualsASCII(parameters.name(), "realm")) 43 if (!base::LowerCaseEqualsASCII(parameters.name(), "realm"))
44 continue; 44 continue;
45 45
46 if (!ConvertToUtf8AndNormalize(parameters.value(), kCharsetLatin1, realm)) { 46 if (!ConvertToUtf8AndNormalize(parameters.value(), kCharsetLatin1, realm)) {
47 return false; 47 return false;
48 } 48 }
49 } 49 }
50 return parameters.valid(); 50 return parameters.valid();
51 } 51 }
52 52
53 } // namespace 53 } // namespace
54 54
55 bool HttpAuthHandlerBasic::Init(HttpAuthChallengeTokenizer* challenge) { 55 bool HttpAuthHandlerBasic::Init(HttpAuthChallengeTokenizer* challenge) {
56 auth_scheme_ = HttpAuth::AUTH_SCHEME_BASIC; 56 auth_scheme_ = HttpAuth::AUTH_SCHEME_BASIC;
57 score_ = 1; 57 score_ = 1;
58 properties_ = 0; 58 properties_ = 0;
59 return ParseChallenge(challenge); 59 return ParseChallenge(challenge);
60 } 60 }
61 61
62 bool HttpAuthHandlerBasic::ParseChallenge( 62 bool HttpAuthHandlerBasic::ParseChallenge(
63 HttpAuthChallengeTokenizer* challenge) { 63 HttpAuthChallengeTokenizer* challenge) {
64 // Verify the challenge's auth-scheme. 64 // Verify the challenge's auth-scheme.
65 if (!LowerCaseEqualsASCII(challenge->scheme(), "basic")) 65 if (!base::LowerCaseEqualsASCII(challenge->scheme(), "basic"))
66 return false; 66 return false;
67 67
68 std::string realm; 68 std::string realm;
69 if (!ParseRealm(*challenge, &realm)) 69 if (!ParseRealm(*challenge, &realm))
70 return false; 70 return false;
71 71
72 realm_ = realm; 72 realm_ = realm;
73 return true; 73 return true;
74 } 74 }
75 75
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 // TODO(cbentzel): Move towards model of parsing in the factory 116 // TODO(cbentzel): Move towards model of parsing in the factory
117 // method and only constructing when valid. 117 // method and only constructing when valid.
118 scoped_ptr<HttpAuthHandler> tmp_handler(new HttpAuthHandlerBasic()); 118 scoped_ptr<HttpAuthHandler> tmp_handler(new HttpAuthHandlerBasic());
119 if (!tmp_handler->InitFromChallenge(challenge, target, origin, net_log)) 119 if (!tmp_handler->InitFromChallenge(challenge, target, origin, net_log))
120 return ERR_INVALID_RESPONSE; 120 return ERR_INVALID_RESPONSE;
121 handler->swap(tmp_handler); 121 handler->swap(tmp_handler);
122 return OK; 122 return OK;
123 } 123 }
124 124
125 } // namespace net 125 } // namespace net
OLDNEW
« no previous file with comments | « net/http/http_auth_gssapi_posix.cc ('k') | net/http/http_auth_handler_digest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698