Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1172723002: Add a proper material shadow the popup menu (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Matt Perry, eseidel
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -85 lines) Patch
M sky/examples/raw/shadowed_box.dart View 1 chunk +13 lines, -7 lines 0 comments Download
M sky/sdk/lib/framework/components2/popup_menu.dart View 2 chunks +10 lines, -10 lines 0 comments Download
M sky/sdk/lib/framework/rendering/box.dart View 4 chunks +56 lines, -62 lines 0 comments Download
M sky/sdk/lib/framework/theme2/shadows.dart View 1 chunk +54 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
5 years, 6 months ago (2015-06-09 17:26:42 UTC) #1
eseidel
lgtm
5 years, 6 months ago (2015-06-09 17:28:21 UTC) #3
abarth-chromium
5 years, 6 months ago (2015-06-09 17:31:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
109640b307b7d34feae25a04c7af81dac4a5a7c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698