Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: sky/sdk/lib/framework/components2/popup_menu.dart

Issue 1172723002: Add a proper material shadow the popup menu (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/examples/raw/shadowed_box.dart ('k') | sky/sdk/lib/framework/rendering/box.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/framework/components2/popup_menu.dart
diff --git a/sky/sdk/lib/framework/components2/popup_menu.dart b/sky/sdk/lib/framework/components2/popup_menu.dart
index a398980bf594da7b6aee5dad2ba09865b96a9fca..184a627891abc551038ce83ab77216dc63d56660 100644
--- a/sky/sdk/lib/framework/components2/popup_menu.dart
+++ b/sky/sdk/lib/framework/components2/popup_menu.dart
@@ -2,10 +2,11 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-import 'animated_component.dart';
import '../animation/animated_value.dart';
import '../fn2.dart';
import '../theme2/colors.dart';
+import '../theme2/shadows.dart';
+import 'animated_component.dart';
import 'dart:async';
import 'dart:math' as math;
import 'material.dart';
@@ -98,16 +99,15 @@ class PopupMenu extends AnimatedComponent {
return new PopupMenuItem(key: i++, children: item, opacity: opacity);
}));
+ // border-radius: 2px
+ // inlineStyle: _inlineStyle(),
return new ShrinkWrapWidth(
- child: new Material(
- content: new Container(
- padding: const EdgeDims.all(8.0),
- // border-radius: 2px
- decoration: new BoxDecoration(backgroundColor: Grey[50]),
- // inlineStyle: _inlineStyle(),
- child: new BlockContainer(children: children)
- ),
- level: level
+ child: new Container(
+ padding: const EdgeDims.all(8.0),
+ decoration: new BoxDecoration(
+ backgroundColor: Grey[50],
+ boxShadow: Shadow[level]),
+ child: new BlockContainer(children: children)
)
);
}
« no previous file with comments | « sky/examples/raw/shadowed_box.dart ('k') | sky/sdk/lib/framework/rendering/box.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698