src/gpu/SkGpuDevice.cpp - Issue 1172693002: remove subclassing from ImageFilter::Proxy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/SkGpuDevice.cpp

Issue 1172693002: remove subclassing from ImageFilter::Proxy (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/SkGpuDevice.cpp

diff --git a/src/gpu/SkGpuDevice.cpp b/src/gpu/SkGpuDevice.cpp

index beed2fab286bcd88a16d62168b7d1b5727a30e7e..8bd5b5ebd543d0452453db8c2781903e27a5dc6a 100644

--- a/src/gpu/SkGpuDevice.cpp

+++ b/src/gpu/SkGpuDevice.cpp

@@ -18,7 +18,6 @@

#include "GrTextContext.h"

#include "GrTracing.h"

#include "SkCanvasPriv.h"

-#include "SkDeviceImageFilterProxy.h"

#include "SkDrawProcs.h"

#include "SkErrorInternals.h"

#include "SkGlyphCache.h"

@@ -1243,7 +1242,7 @@ bool SkGpuDevice::filterTexture(GrContext* context, GrTexture* texture,

// FIXME: plumb actual surface props such that we don't have to lie about the flags here

// (https://code.google.com/p/skia/issues/detail?id=3148).

- SkDeviceImageFilterProxy proxy(this, SkSurfaceProps(0, getLeakyProperties().pixelGeometry()));

+ SkImageFilter::Proxy proxy(this, SkSurfaceProps(0, getLeakyProperties().pixelGeometry()));

if (filter->canFilterImageGPU()) {

return filter->filterImageGPU(&proxy, wrap_texture(texture, width, height),