Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2134)

Unified Diff: Source/devtools/front_end/sources/ServiceWorkersSidebarPane.js

Issue 1172643002: DevTools: migrate sidebar pane's titleElement to use Toolbar. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebaselined Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/sources/ServiceWorkersSidebarPane.js
diff --git a/Source/devtools/front_end/sources/ServiceWorkersSidebarPane.js b/Source/devtools/front_end/sources/ServiceWorkersSidebarPane.js
index a57a5c05b4e5fb249d558ff57ee1f102ee83d763..0987799c4c2f83ca974a658ddc32db02d34f71a2 100644
--- a/Source/devtools/front_end/sources/ServiceWorkersSidebarPane.js
+++ b/Source/devtools/front_end/sources/ServiceWorkersSidebarPane.js
@@ -11,6 +11,7 @@ WebInspector.ServiceWorkersSidebarPane = function()
{
WebInspector.SidebarPane.call(this, WebInspector.UIString("\u2699 Service Workers"));
this.registerRequiredCSS("sources/serviceWorkersSidebar.css");
+ this._bodyElement = this.element.createChild("div", "vbox");
this.setVisible(false);
/** @type {?WebInspector.ServiceWorkerManager} */
@@ -47,18 +48,18 @@ WebInspector.ServiceWorkersSidebarPane.prototype = {
_update: function()
{
this._updateVisibility();
- this.bodyElement.removeChildren();
+ this._bodyElement.removeChildren();
if (!this.isShowing() || !this._manager)
return;
if (!this._manager.hasWorkers()) {
- this.bodyElement.appendChild(this._placeholderElement);
+ this._bodyElement.appendChild(this._placeholderElement);
return;
}
for (var worker of this._manager.workers()) {
- var workerElement = this.bodyElement.createChild("div", "service-worker");
+ var workerElement = this._bodyElement.createChild("div", "service-worker");
var leftBox = workerElement.createChild("div", "vbox flex-auto");
leftBox.appendChild(WebInspector.linkifyURLAsNode(worker.url(), worker.name()));
var scopeElement = leftBox.createChild("span", "service-worker-scope");

Powered by Google App Engine
This is Rietveld 408576698