Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js

Issue 1172643002: DevTools: migrate sidebar pane's titleElement to use Toolbar. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebaselined Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js
diff --git a/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js b/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js
index 6aee2ea526b19753003132230e413c579811aa59..9ca670b9daab057e3f1cdadbc76a674e1368e8dc 100644
--- a/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js
+++ b/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js
@@ -18,7 +18,7 @@ WebInspector.JavaScriptBreakpointsSidebarPane = function(breakpointManager, show
this.listElement = createElementWithClass("ol", "breakpoint-list");
- this.emptyElement = this.bodyElement.createChild("div", "info");
+ this.emptyElement = this.element.createChild("div", "info");
this.emptyElement.textContent = WebInspector.UIString("No Breakpoints");
this._items = new Map();
@@ -75,9 +75,8 @@ WebInspector.JavaScriptBreakpointsSidebarPane.prototype = {
element.addEventListener("contextmenu", this._breakpointContextMenu.bind(this, breakpoint), true);
element.addEventListener("click", this._breakpointClicked.bind(this, uiLocation), false);
- var checkbox = element.createChild("input", "checkbox-elem");
- checkbox.type = "checkbox";
- checkbox.checked = breakpoint.enabled();
+ var checkbox = createCheckboxLabel("", breakpoint.enabled());
+ element.appendChild(checkbox);
checkbox.addEventListener("click", this._breakpointCheckboxClicked.bind(this, breakpoint), false);
element.createTextChild(uiLocation.linkText());
dgozman 2015/06/09 13:27:02 Make this checkbox title instead of "".
pfeldman 2015/06/09 13:40:59 Done.
@@ -212,8 +211,8 @@ WebInspector.JavaScriptBreakpointsSidebarPane.prototype = {
this.listElement.insertBefore(element, beforeElement);
else {
if (!this.listElement.firstChild) {
- this.bodyElement.removeChild(this.emptyElement);
- this.bodyElement.appendChild(this.listElement);
+ this.element.removeChild(this.emptyElement);
+ this.element.appendChild(this.listElement);
}
this.listElement.appendChild(element);
}
@@ -223,8 +222,8 @@ WebInspector.JavaScriptBreakpointsSidebarPane.prototype = {
{
this.listElement.removeChild(element);
if (!this.listElement.firstChild) {
- this.bodyElement.removeChild(this.listElement);
- this.bodyElement.appendChild(this.emptyElement);
+ this.element.removeChild(this.listElement);
+ this.element.appendChild(this.emptyElement);
}
},
@@ -244,8 +243,8 @@ WebInspector.JavaScriptBreakpointsSidebarPane.prototype = {
{
this.listElement.removeChildren();
if (this.listElement.parentElement) {
- this.bodyElement.removeChild(this.listElement);
- this.bodyElement.appendChild(this.emptyElement);
+ this.element.removeChild(this.listElement);
+ this.element.appendChild(this.emptyElement);
}
this._items.clear();
},

Powered by Google App Engine
This is Rietveld 408576698