Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 1172603004: Fix crash when an onorientationchange event detaches an iframe. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/tests/WebFrameTest.cpp
diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp
index a8c8b22ba93b3a724f0bee68b1e325ceed65fb62..4ba5c6abac73a93313e60c7177fdb4f04f4f4ab2 100644
--- a/Source/web/tests/WebFrameTest.cpp
+++ b/Source/web/tests/WebFrameTest.cpp
@@ -7718,4 +7718,13 @@ TEST_F(WebFrameOverscrollTest, ScaledPageRootLayerOverscrolled)
Mock::VerifyAndClearExpectations(&client);
}
+TEST_F(WebFrameTest, OrientationFrameDetach)
+{
+ RuntimeEnabledFeatures::setOrientationEventEnabled(true);
+ registerMockedHttpURLLoad("orientation-frame-detach.html");
+ FrameTestHelpers::WebViewHelper webViewHelper;
+ WebViewImpl* webViewImpl = webViewHelper.initializeAndLoad(m_baseURL + "orientation-frame-detach.html", true);
+ webViewImpl->mainFrameImpl()->sendOrientationChangeEvent();
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698