Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: Source/web/tests/WebFrameTest.cpp

Issue 1172603004: Fix crash when an onorientationchange event detaches an iframe. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 7700 matching lines...) Expand 10 before | Expand all | Expand 10 after
7711 EXPECT_CALL(client, didOverscroll(WebFloatSize(-10, 0), WebFloatSize(-20, -3 0), WebFloatPoint(33, 33), WebFloatSize())); 7711 EXPECT_CALL(client, didOverscroll(WebFloatSize(-10, 0), WebFloatSize(-20, -3 0), WebFloatPoint(33, 33), WebFloatSize()));
7712 ScrollUpdate(&webViewHelper, 30, 0); 7712 ScrollUpdate(&webViewHelper, 30, 0);
7713 Mock::VerifyAndClearExpectations(&client); 7713 Mock::VerifyAndClearExpectations(&client);
7714 7714
7715 // Overscroll is not reported. 7715 // Overscroll is not reported.
7716 EXPECT_CALL(client, didOverscroll(WebFloatSize(), WebFloatSize(), WebFloatPo int(33, 33), WebFloatSize())).Times(0); 7716 EXPECT_CALL(client, didOverscroll(WebFloatSize(), WebFloatSize(), WebFloatPo int(33, 33), WebFloatSize())).Times(0);
7717 ScrollEnd(&webViewHelper); 7717 ScrollEnd(&webViewHelper);
7718 Mock::VerifyAndClearExpectations(&client); 7718 Mock::VerifyAndClearExpectations(&client);
7719 } 7719 }
7720 7720
7721 TEST_F(WebFrameTest, OrientationFrameDetach)
7722 {
7723 RuntimeEnabledFeatures::setOrientationEventEnabled(true);
7724 registerMockedHttpURLLoad("orientation-frame-detach.html");
7725 FrameTestHelpers::WebViewHelper webViewHelper;
7726 WebViewImpl* webViewImpl = webViewHelper.initializeAndLoad(m_baseURL + "orie ntation-frame-detach.html", true);
7727 webViewImpl->mainFrameImpl()->sendOrientationChangeEvent();
7728 }
7729
7721 } // namespace blink 7730 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698