Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5566)

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc

Issue 11726002: Move the parsing of 'update_url' & 'options_page' URLs out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@url_parse
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc
index 6d396fe97c352f937403c269d8748caaba762b80..086f8ecee7c7e1856854e091e9f6f6277b768815 100644
--- a/chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc
+++ b/chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc
@@ -2,16 +2,28 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
-
#include "chrome/common/extensions/extension_manifest_constants.h"
+#include "chrome/common/extensions/manifest_handler.h"
+#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
+#include "chrome/common/extensions/update_url_handler.h"
#include "testing/gtest/include/gtest/gtest.h"
using extensions::Extension;
+namespace keys = extension_manifest_keys;
namespace errors = extension_manifest_errors;
-TEST_F(ExtensionManifestTest, UpdateUrls) {
+namespace {
+
+class UpdateURLManifestTest : public ExtensionManifestTest {
+ virtual void SetUp() OVERRIDE {
+ ExtensionManifestTest::SetUp();
+ extensions::ManifestHandler::Register(keys::kUpdateURL,
+ new extensions::UpdateURLHandler);
+ }
+};
+
+TEST_F(UpdateURLManifestTest, UpdateUrls) {
// Test several valid update urls
Testcase testcases[] = {
Testcase("update_url_valid_1.json", Extension::INTERNAL,
@@ -38,3 +50,5 @@ TEST_F(ExtensionManifestTest, UpdateUrls) {
RunTestcases(testcases2, arraysize(testcases2),
EXPECT_TYPE_ERROR);
}
+
+} // namespace

Powered by Google App Engine
This is Rietveld 408576698