Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc

Issue 11726002: Move the parsing of 'update_url' & 'options_page' URLs out of Extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@url_parse
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/extension_manifest_constants.h"
6 #include "chrome/common/extensions/manifest_handler.h"
5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 7 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
6 8 #include "chrome/common/extensions/update_url_handler.h"
7 #include "chrome/common/extensions/extension_manifest_constants.h"
8 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
9 10
10 using extensions::Extension; 11 using extensions::Extension;
11 12
13 namespace keys = extension_manifest_keys;
12 namespace errors = extension_manifest_errors; 14 namespace errors = extension_manifest_errors;
13 15
14 TEST_F(ExtensionManifestTest, UpdateUrls) { 16 namespace {
17
18 class UpdateURLManifestTest : public ExtensionManifestTest {
19 virtual void SetUp() OVERRIDE {
20 ExtensionManifestTest::SetUp();
21 extensions::ManifestHandler::Register(keys::kUpdateURL,
22 new extensions::UpdateURLHandler);
23 }
24 };
25
26 TEST_F(UpdateURLManifestTest, UpdateUrls) {
15 // Test several valid update urls 27 // Test several valid update urls
16 Testcase testcases[] = { 28 Testcase testcases[] = {
17 Testcase("update_url_valid_1.json", Extension::INTERNAL, 29 Testcase("update_url_valid_1.json", Extension::INTERNAL,
18 Extension::NO_FLAGS), 30 Extension::NO_FLAGS),
19 Testcase("update_url_valid_2.json", Extension::INTERNAL, 31 Testcase("update_url_valid_2.json", Extension::INTERNAL,
20 Extension::NO_FLAGS), 32 Extension::NO_FLAGS),
21 Testcase("update_url_valid_3.json", Extension::INTERNAL, 33 Testcase("update_url_valid_3.json", Extension::INTERNAL,
22 Extension::NO_FLAGS), 34 Extension::NO_FLAGS),
23 Testcase("update_url_valid_4.json", Extension::INTERNAL, 35 Testcase("update_url_valid_4.json", Extension::INTERNAL,
24 Extension::NO_FLAGS) 36 Extension::NO_FLAGS)
25 }; 37 };
26 RunTestcases(testcases, arraysize(testcases), 38 RunTestcases(testcases, arraysize(testcases),
27 EXPECT_TYPE_SUCCESS); 39 EXPECT_TYPE_SUCCESS);
28 40
29 // Test some invalid update urls 41 // Test some invalid update urls
30 Testcase testcases2[] = { 42 Testcase testcases2[] = {
31 Testcase("update_url_invalid_1.json", errors::kInvalidUpdateURL, 43 Testcase("update_url_invalid_1.json", errors::kInvalidUpdateURL,
32 Extension::INTERNAL, Extension::NO_FLAGS), 44 Extension::INTERNAL, Extension::NO_FLAGS),
33 Testcase("update_url_invalid_2.json", errors::kInvalidUpdateURL, 45 Testcase("update_url_invalid_2.json", errors::kInvalidUpdateURL,
34 Extension::INTERNAL, Extension::NO_FLAGS), 46 Extension::INTERNAL, Extension::NO_FLAGS),
35 Testcase("update_url_invalid_3.json", errors::kInvalidUpdateURL, 47 Testcase("update_url_invalid_3.json", errors::kInvalidUpdateURL,
36 Extension::INTERNAL, Extension::NO_FLAGS) 48 Extension::INTERNAL, Extension::NO_FLAGS)
37 }; 49 };
38 RunTestcases(testcases2, arraysize(testcases2), 50 RunTestcases(testcases2, arraysize(testcases2),
39 EXPECT_TYPE_ERROR); 51 EXPECT_TYPE_ERROR);
40 } 52 }
53
54 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698