[MacViews] Update AppWindow when the native window changes fullscreen state.

extensions/browser/app_window/app_window.cc

Index: extensions/browser/app_window/app_window.cc
diff --git a/extensions/browser/app_window/app_window.cc b/extensions/browser/app_window/app_window.cc
index c1959a98c82541c665e543ff7fba235de8b74b5f..c23fda7313c42390e747eb90af64d8926e56e2fc 100644
--- a/extensions/browser/app_window/app_window.cc
+++ b/extensions/browser/app_window/app_window.cc
@@ -603,6 +603,17 @@ void AppWindow::OSFullscreen() {
   SetFullscreen(FULLSCREEN_TYPE_OS, true);
 }
 
+void AppWindow::UpdateOSFullscreenState(bool is_fullscreen) {
+  if (is_fullscreen) {
+    fullscreen_types_ |= FULLSCREEN_TYPE_OS;

[tapted, 2015/06/09 06:04:01]

why not just `=`? i.e. shouldn't this override any other way of going
fullscreen?

[jackhou1, 2015/06/10 05:06:03]

Yes, but the way it works now in patch set 5 means that any type of fullscreen
will also set FULLSCREEN_TYPE_OS, but it should not override the other types.

+  } else {
+    fullscreen_types_ = FULLSCREEN_TYPE_NONE;
+    SetNativeWindowFullscreen();

[tapted, 2015/06/09 06:04:01]

Is this still needed?

[jackhou1, 2015/06/10 05:06:03]

It's needed to set the always-on-top state. But that should be done when
entering fullscreen too.

+  }
+
+  OnNativeWindowChanged();

[tapted, 2015/06/09 06:04:01]

What about just rolling the fullscreen check into OnNativeWindowChanged()?

And... actually, does a call into void
NativeAppWindowViews::SaveWindowPlacement(..) already occur for fullscreen
changes?  (maybe we don't need that widgetobserver hook after all)

[jackhou1, 2015/06/10 05:06:03]

Done.

+}
+
 void AppWindow::ForcedFullscreen() {
   SetFullscreen(FULLSCREEN_TYPE_FORCED, true);
 }