[MacViews] Update AppWindow when the native window changes fullscreen state.

extensions/browser/app_window/app_window.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/app_window/app_window.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
@@ skipping 585 matching lines @@
     SetNativeWindowFullscreen();
   } else {
     GetBaseWindow()->Restore();
   }
 }
 
 void AppWindow::OSFullscreen() {
   SetFullscreen(FULLSCREEN_TYPE_OS, true);
 }
 
+void AppWindow::UpdateOSFullscreenState(bool is_fullscreen) {
+  if (is_fullscreen) {
+    fullscreen_types_ |= FULLSCREEN_TYPE_OS;

[tapted, 2015/06/09 06:04:01]

why not just `=`? i.e. shouldn't this override any other way of going
fullscreen?

[jackhou1, 2015/06/10 05:06:03]

Yes, but the way it works now in patch set 5 means that any type of fullscreen
will also set FULLSCREEN_TYPE_OS, but it should not override the other types.

+  } else {
+    fullscreen_types_ = FULLSCREEN_TYPE_NONE;
+    SetNativeWindowFullscreen();

[tapted, 2015/06/09 06:04:01]

Is this still needed?

[jackhou1, 2015/06/10 05:06:03]

It's needed to set the always-on-top state. But that should be done when
entering fullscreen too.

+  }
+
+  OnNativeWindowChanged();

[tapted, 2015/06/09 06:04:01]

What about just rolling the fullscreen check into OnNativeWindowChanged()?

And... actually, does a call into void
NativeAppWindowViews::SaveWindowPlacement(..) already occur for fullscreen
changes?  (maybe we don't need that widgetobserver hook after all)

[jackhou1, 2015/06/10 05:06:03]

Done.

+}
+
 void AppWindow::ForcedFullscreen() {
   SetFullscreen(FULLSCREEN_TYPE_FORCED, true);
 }
 
 void AppWindow::SetContentSizeConstraints(const gfx::Size& min_size,
                                           const gfx::Size& max_size) {
   SizeConstraints constraints(min_size, max_size);
   native_app_window_->SetContentSizeConstraints(constraints.GetMinimumSize(),
                                                 constraints.GetMaximumSize());
 
@@ skipping 445 matching lines @@
         region.bounds.x(),
         region.bounds.y(),
         region.bounds.right(),
         region.bounds.bottom(),
         region.draggable ? SkRegion::kUnion_Op : SkRegion::kDifference_Op);
   }
   return sk_region;
 }
 
 }  // namespace extensions