Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 117233008: Linux Aura: Hide title bar when browser windows are maximized on Unity. (Closed)

Created:
7 years ago by Matt Giuca
Modified:
3 years, 4 months ago
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Linux Aura: Hide title bar when browser windows are maximized on Unity. This avoids showing a double title bar on browser windows without a tab strip, such as popups, Developer Tools and V1 app windows. BUG=330090 TEST=On Unity, maximize Developer Tools window. There should be only the Unity title and caption buttons, no blue custom title bar. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243536

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Avoid NULL dereference on Windows. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view_linux.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view_linux.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view_platform_specific.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view_platform_specific.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Matt Giuca
FYI: Sister CL to do the same thing for custom frame windows: https://codereview.chromium.org/98793009
7 years ago (2013-12-20 04:29:24 UTC) #1
Ben Goodger (Google)
lgtm
7 years ago (2013-12-20 21:28:06 UTC) #2
James Cook
lgtm
7 years ago (2013-12-20 21:35:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/117233008/1
7 years ago (2013-12-23 01:36:52 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=239682
7 years ago (2013-12-23 02:35:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/117233008/1
6 years, 11 months ago (2014-01-06 00:51:50 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=241734
6 years, 11 months ago (2014-01-06 01:47:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/117233008/610001
6 years, 11 months ago (2014-01-06 04:06:09 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=241760
6 years, 11 months ago (2014-01-06 07:22:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/117233008/610001
6 years, 11 months ago (2014-01-07 00:38:52 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242343
6 years, 11 months ago (2014-01-07 13:08:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/117233008/610001
6 years, 11 months ago (2014-01-07 23:13:08 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242941
6 years, 11 months ago (2014-01-08 04:01:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/117233008/610001
6 years, 11 months ago (2014-01-08 05:38:39 UTC) #14
commit-bot: I haz the power
Change committed as 243536
6 years, 11 months ago (2014-01-08 12:38:12 UTC) #15
teambuildvngroup
Using Chrome Extensions To Get Leads And Traffic Fast https://onmogul.com/ask_anythings/chromengage-review-what-is-my-honest-chromengage-review https://onmogul.com/ask_anythings/chromengage-bonus-what-is-best-chromengage-bonus http://lanyrd.com/2017/social-video-jukebox-best-review/calls/qfmkb/
3 years, 4 months ago (2017-08-18 17:30:47 UTC) #16
teambuildvngroup
3 years, 4 months ago (2017-08-18 17:35:39 UTC) #17
Message was sent while issue was closed. 
On 2017/08/18 17:30:47, teambuildvngroup wrote:
> Using Chrome Extensions To Get Leads And Traffic Fast


http://lanyrd.com/2017/list-janitor-free-download/calls/qfmkc/

Powered by Google App Engine
This is Rietveld 408576698