chrome/browser/ui/views/frame/opaque_browser_frame_view_linux.cc - Issue 117233008: Linux Aura: Hide title bar when browser windows are maximized on Unity.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/opaque_browser_frame_view_linux.cc

Issue 117233008: Linux Aura: Hide title bar when browser windows are maximized on Unity. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Avoid NULL dereference on Windows. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/opaque_browser_frame_view_linux.h ('k') | chrome/browser/ui/views/frame/opaque_browser_frame_view_platform_specific.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/opaque_browser_frame_view_linux.cc

diff --git a/chrome/browser/ui/views/frame/opaque_browser_frame_view_linux.cc b/chrome/browser/ui/views/frame/opaque_browser_frame_view_linux.cc

index 9d7995c3101888ae95ce3277ee5619efddc05529..f0def59e991f76fb430da6f6e6536934e2334ce6 100644

--- a/chrome/browser/ui/views/frame/opaque_browser_frame_view_linux.cc

+++ b/chrome/browser/ui/views/frame/opaque_browser_frame_view_linux.cc

@@ -38,6 +38,13 @@ bool OpaqueBrowserFrameViewLinux::ShouldShowCaptionButtons() const {

return !(view_->IsMaximized() && ui && ui->UnityIsRunning());

}

+bool OpaqueBrowserFrameViewLinux::ShouldShowTitleBar() const {

+ // On Ubuntu Unity, if the window is maximized, the system will provide

+ // a title bar, so Chrome should not add its own.

+ views::LinuxUI* ui = views::LinuxUI::instance();

+ return !(view_->IsMaximized() && ui && ui->UnityIsRunning());

///////////////////////////////////////////////////////////////////////////////

// OpaqueBrowserFrameViewLinux,

// views::WindowButtonOrderObserver implementation: