Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 11722017: Use an explicit PID for duplicating Pepper handles rather than the Channel's. (Closed)

Created:
7 years, 11 months ago by brettw
Modified:
7 years, 11 months ago
Reviewers:
jschuh
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, native-client-reviews_googlegroups.com, darin-cc_chromium.org
Visibility:
Public.

Description

Use an explicit PID for duplicating Pepper handles rather than the Channel's. When the browser process launches the plugin, it explicitly tells each side the PID of the other side, and we now use this PID for sharing handles. Previously we'd use the PID from the IPC channel. Using the PID from the IPC channel creates a race condition because the PID isn't set until the "hello" message from the opposite side is processed, which isn't guaranteed at any particular time. BUG=168222 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175190

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -65 lines) Patch
M chrome/browser/nacl_host/nacl_process_host.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/common/render_messages.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/pepper/ppb_nacl_private_impl.cc View 3 chunks +4 lines, -1 line 0 comments Download
M content/browser/pepper_flash_settings_helper_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/pepper_flash_settings_helper_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/plugin_data_remover_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/plugin_service_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 3 chunks +12 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 2 chunks +10 lines, -7 lines 0 comments Download
M content/common/view_messages.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/ppapi_plugin/ppapi_thread.h View 3 chunks +6 lines, -3 lines 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 6 chunks +13 lines, -7 lines 0 comments Download
M content/public/browser/child_process_data.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/renderer/renderer_ppapi_host.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/pepper/pepper_broker_impl.h View 3 chunks +5 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_broker_impl.cc View 3 chunks +4 lines, -1 line 0 comments Download
M content/renderer/pepper/pepper_broker_impl_unittest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.h View 3 chunks +3 lines, -0 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 10 chunks +15 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_proxy_channel_delegate_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_proxy_channel_delegate_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/renderer_ppapi_host_impl.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_pepper_helper.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ipc/ipc_channel.h View 1 chunk +8 lines, -1 line 0 comments Download
M ppapi/proxy/broker_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/broker_dispatcher.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ppapi/proxy/host_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/host_dispatcher.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ppapi/proxy/plugin_dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/plugin_dispatcher.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ppapi/proxy/plugin_main_nacl.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 chunk +3 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 1 2 4 chunks +5 lines, -3 lines 0 comments Download
M ppapi/proxy/proxy_channel.h View 4 chunks +9 lines, -2 lines 0 comments Download
M ppapi/proxy/proxy_channel.cc View 5 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
7 years, 11 months ago (2013-01-03 21:53:12 UTC) #1
jschuh
On 2013/01/03 21:53:12, brettw wrote: lgtm
7 years, 11 months ago (2013-01-03 22:21:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/11722017/4005
7 years, 11 months ago (2013-01-04 06:27:48 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-04 06:28:16 UTC) #4
Presubmit check for 11722017-4005 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    ipc

Presubmit checks took 3.1s to calculate.

Powered by Google App Engine
This is Rietveld 408576698