Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Side by Side Diff: content/renderer/pepper/pepper_broker_impl_unittest.cc

Issue 11722017: Use an explicit PID for duplicating Pepper handles rather than the Channel's. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/pepper/pepper_broker_impl.h" 5 #include "content/renderer/pepper/pepper_broker_impl.h"
6 6
7 #if defined(OS_POSIX) 7 #if defined(OS_POSIX)
8 #include <fcntl.h> 8 #include <fcntl.h>
9 #include <sys/socket.h> 9 #include <sys/socket.h>
10 #endif // defined(OS_POSIX) 10 #endif // defined(OS_POSIX)
(...skipping 13 matching lines...) Expand all
24 // Try to initialize PepperBrokerDispatcherWrapper with invalid ChannelHandle. 24 // Try to initialize PepperBrokerDispatcherWrapper with invalid ChannelHandle.
25 // Initialization should fail. 25 // Initialization should fail.
26 TEST_F(PepperBrokerImplTest, InitFailure) { 26 TEST_F(PepperBrokerImplTest, InitFailure) {
27 PepperBrokerDispatcherWrapper dispatcher_wrapper; 27 PepperBrokerDispatcherWrapper dispatcher_wrapper;
28 IPC::ChannelHandle invalid_channel; // Invalid by default. 28 IPC::ChannelHandle invalid_channel; // Invalid by default.
29 29
30 // An invalid handle should result in a failure (false) without a LOG(FATAL), 30 // An invalid handle should result in a failure (false) without a LOG(FATAL),
31 // such as the one in CreatePipe(). Call it twice because without the invalid 31 // such as the one in CreatePipe(). Call it twice because without the invalid
32 // handle check, the posix code would hit a one-time path due to a static 32 // handle check, the posix code would hit a one-time path due to a static
33 // variable and go through the LOG(FATAL) path. 33 // variable and go through the LOG(FATAL) path.
34 EXPECT_FALSE(dispatcher_wrapper.Init(invalid_channel)); 34 EXPECT_FALSE(dispatcher_wrapper.Init(base::kNullProcessId, invalid_channel));
35 EXPECT_FALSE(dispatcher_wrapper.Init(invalid_channel)); 35 EXPECT_FALSE(dispatcher_wrapper.Init(base::kNullProcessId, invalid_channel));
36 } 36 }
37 37
38 // On valid ChannelHandle, initialization should succeed. 38 // On valid ChannelHandle, initialization should succeed.
39 TEST_F(PepperBrokerImplTest, InitSuccess) { 39 TEST_F(PepperBrokerImplTest, InitSuccess) {
40 PepperBrokerDispatcherWrapper dispatcher_wrapper; 40 PepperBrokerDispatcherWrapper dispatcher_wrapper;
41 const char kChannelName[] = "PepperPluginDelegateImplTestChannelName"; 41 const char kChannelName[] = "PepperPluginDelegateImplTestChannelName";
42 #if defined(OS_POSIX) 42 #if defined(OS_POSIX)
43 int fds[2] = {-1, -1}; 43 int fds[2] = {-1, -1};
44 ASSERT_EQ(0, socketpair(AF_UNIX, SOCK_STREAM, 0, fds)); 44 ASSERT_EQ(0, socketpair(AF_UNIX, SOCK_STREAM, 0, fds));
45 // Channel::ChannelImpl::CreatePipe needs the fd to be non-blocking. 45 // Channel::ChannelImpl::CreatePipe needs the fd to be non-blocking.
46 ASSERT_EQ(0, fcntl(fds[1], F_SETFL, O_NONBLOCK)); 46 ASSERT_EQ(0, fcntl(fds[1], F_SETFL, O_NONBLOCK));
47 base::FileDescriptor file_descriptor(fds[1], true); // Auto close. 47 base::FileDescriptor file_descriptor(fds[1], true); // Auto close.
48 IPC::ChannelHandle valid_channel(kChannelName, file_descriptor); 48 IPC::ChannelHandle valid_channel(kChannelName, file_descriptor);
49 #else 49 #else
50 IPC::ChannelHandle valid_channel(kChannelName); 50 IPC::ChannelHandle valid_channel(kChannelName);
51 #endif // defined(OS_POSIX)); 51 #endif // defined(OS_POSIX));
52 52
53 EXPECT_TRUE(dispatcher_wrapper.Init(valid_channel)); 53 EXPECT_TRUE(dispatcher_wrapper.Init(base::kNullProcessId, valid_channel));
54 54
55 #if defined(OS_POSIX) 55 #if defined(OS_POSIX)
56 EXPECT_EQ(0, ::close(fds[0])); 56 EXPECT_EQ(0, ::close(fds[0]));
57 #endif // defined(OS_POSIX)); 57 #endif // defined(OS_POSIX));
58 } 58 }
59 59
60 } // namespace content 60 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/pepper/pepper_broker_impl.cc ('k') | content/renderer/pepper/pepper_plugin_delegate_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698