Chromium Code Reviews Chromium Code Reviews
Issue
1171913003:
**** [WIP] Blink-side: Implement FetchBlobDataConsumerHandle **** (Closed)
DescriptionBUG=480746
Status as of Monday night:
Rebased on Chromium 335488
Remaining Blink-side dependencies:
- [3b] https://codereview.chromium.org/1178043004/ Use Handle in FetchManager::Loader
- [1b] https://codereview.chromium.org/1176403006/ FetchBlobDataConsumerHandle
- [2c] https://codereview.chromium.org/1173173006/ readAsyncFromFetchDataConsumerHandle
- https://codereview.chromium.org/1195563002/
- https://codereview.chromium.org/1198443002/
- (low pri) https://codereview.chromium.org/1198313002/
Remaining Chromium-side dependencies:
[C3] https://codereview.chromium.org/1186053004/ Cancel Loading when body the stream reader is detached.
Remaining changes:
+517 -570 Lines
Test status:
http/tests/serviceworker/chromium/fetch-error-messages.html FAILURE
FAIL Fetch API error message - invalid chunked encoding. assert_unreached: unexpected rejection: assert_equals: expected (string) "Failed to fetch" but got (undefined) undefined Reached unreachable code
All other http/tests/fetch,cachestorage,serviceworker tests passed.
To Do:
- clean up isBodyConsumed().
- clean up populateWebServiceWorkerResponse and code in Cache and ServiceWorker that use it.
- Fix test failures.
- Write unittests of FetchBlobDataConsumerHandle (yhirano).
Memo:
A Cumulative CL including dependent CLs.
Blink-side: This CL.
Chromium-side: https://codereview.chromium.org/1177083002/
Base rev: Blink 196740
Depending on (current CL includes these CLs):
Blink-side:
[1] COMMITED https://codereview.chromium.org/1149563007/ WebDataConsumerHandle::Reader
[2] COMMITED https://codereview.chromium.org/1162043007/ CompositeDataConsumerHandle
Chromium-side:
[C1] COMMITED https://codereview.chromium.org/1164493008/ Implement WebDataConsumerHandle::Reader.
[C2] COMMITED https://codereview.chromium.org/1150033004/ Use SharedMemoryDataConsumerHandle for stream data.
[C3] https://codereview.chromium.org/1186053004/ Cancel Loading when body the stream reader is detached.
[C4] COMMITTED https://codereview.chromium.org/1181573003/ Error notification.
[C5] COMMITED https://codereview.chromium.org/1178763002/ flag fix.
Originally from:
http://crrev.com/1143943004#ps1
This CL will be separated to multiple CLs:
The Patch Set marked as [Base] is [1]+[2]+[3].
[0a] COMMITTED https://codereview.chromium.org/1183373003/ debugName
debugName()
[0b] https://codereview.chromium.org/1179413005/ debugName() in content
[Step 1] (local branch: Fetch_backpressureRebasePS7_branch)
[1a] https://codereview.chromium.org/1176243004/ Utilities
1a. Introduces FetchDataConsumerHandle.
1c. Introduces createUnexpectedErrorHandle().
1d. Introduces FetchEmptyDataConsumerHandle.
[1b] https://codereview.chromium.org/1176403006/ FetchBlobDataConsumerHandle
([0a], [1a])
1b. Introduces FetchBlobDataConsumerHandle. (1a)
TO-BE-CREATED?
1e. Replaces Blob + FileReader (|m_loader|) in Body::ReadableStreamSource. (1a, 1b, 1c, 1d)
[Step 2] (local branch: Fetch_backpressureRebasePS9)
[2a] https://codereview.chromium.org/1179393007/ FetchDataLoader
Introduces FetchDataLoader.
TO-BE-CREATED?
- Introduces Body::dataConsumerHandle().
[2c] https://codereview.chromium.org/1173173006/ readAsyncFromFetchDataConsumerHandle
([0a], [1a], [1b], [2a])
(Patch Set 8, Body.h/cpp, depending on Utility and Blob)
- Replaces readAsyncFromBlob(blobDataHandle()) with readAsyncFromFetchDataConsumerHandle.
[Step 3]
[3a] COMMITTED https://codereview.chromium.org/1186713009/
3a. Add BodyStreamBuffer::createFromDataConsumer().
[3b] https://codereview.chromium.org/1178043004/ Use Handle in FetchManager::Loader
(Patch Set 16, depending on [C3][C4])
3b. Use Handle in FetchManager::Loader.
- Changes in BlobConsumerHandle is not used currently.
- A bug to be merged to Step 2.
To Do:
- Replace BSB with FDCH incrementally.
- Remove Body::blobHandle() if possible.
[Step 6]
test status:
http/tests/cachestorage/*/cache-match.html: timeout
http/tests/cachestorage/window/cache-add.html: console log
http/tests/serviceworker/chromium/fetch-error-messages.html: error message?
http/tests/cachestorage/worker/cache-put.html: assert failure crash. liveness of AsyncPutBatch.
All other passed.
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #Patch Set 4 : #Patch Set 5 : #Patch Set 6 : Base #Patch Set 7 : [Step 1] Replace Body::ReadableStreamSource's blobDataHandle with FetchDataConsumerHandle. #Patch Set 8 : Replace readAsyncFromBlob with readAsyncFromFetchDataConsumerHandle (for blob only #Patch Set 9 : [Base] #Patch Set 10 : [Step 2] #Patch Set 11 : [Step 1] #Patch Set 12 : [Step 2] #Patch Set 13 : [Step 3]: Introduce BodyStreamBuffer::createFromDataConsumerHandle #Patch Set 14 : [Step 3] More on createFromDataConsumer, and use Handle in FetchManager::Loader #Patch Set 15 : [Step 3] #Patch Set 16 : [Step 3] Replace BSB with FDCH: FetchResponseData::createWithBuffer #Patch Set 17 : [Step 4] Replace BodyStreamBuffer with BodyStreamBuffer2. #Patch Set 18 : Bug fix and unused code cleanup. #Patch Set 19 : temp #Patch Set 20 : #Patch Set 21 : [Step 6] remove Body::blobDataHandle() and bug fixes. #Patch Set 22 : [Step 6] #Patch Set 23 : Rebase. #Patch Set 24 : Rebase. #Patch Set 25 : Made BSB2 GCed. #Patch Set 26 : #Patch Set 27 : #Patch Set 28 : Ready, except for one test not passed. #Patch Set 29 : Rebase. #Patch Set 30 : Rebase Compile OK. #Patch Set 31 : BASE #Patch Set 32 : Step 6. #Patch Set 33 : Clean up. #Messages
Total messages: 6 (6 generated)
|
