Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5554)

Unified Diff: Source/modules/fetch/ResponseTest.cpp

Issue 1171913003: **** [WIP] Blink-side: Implement FetchBlobDataConsumerHandle **** (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Clean up. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/fetch/Response.cpp ('k') | Source/modules/modules.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/fetch/ResponseTest.cpp
diff --git a/Source/modules/fetch/ResponseTest.cpp b/Source/modules/fetch/ResponseTest.cpp
index fcaa58e1d2c1745681e91f57fe5f75e27837058f..d5e89f315de37d763d4ae7f7211050fee648aaef 100644
--- a/Source/modules/fetch/ResponseTest.cpp
+++ b/Source/modules/fetch/ResponseTest.cpp
@@ -19,8 +19,9 @@
namespace blink {
namespace {
-const char kTestData[] = "Here is sample text for the blob.";
+// const char kTestData[] = "Here is sample text for the blob.";
+/*
class MockCanceller : public BodyStreamBuffer::Canceller {
public:
MockCanceller() : m_counter(0) { }
@@ -30,6 +31,7 @@ public:
private:
int m_counter;
};
+*/
PassOwnPtr<WebServiceWorkerResponse> createTestWebServiceWorkerResponse()
{
@@ -187,6 +189,7 @@ TEST_F(ServiceWorkerResponseTest, FromWebServiceWorkerResponseOpaque)
EXPECT_FALSE(exceptionState.hadException());
}
+/*
void checkResponseBlobHandle(Response* response, bool hasNonInternalBlobHandle, const unsigned long long blobSize)
{
EXPECT_TRUE(response->internalBlobDataHandle());
@@ -220,7 +223,9 @@ void checkResponseBlobHandle(Response* response, bool hasNonInternalBlobHandle,
EXPECT_FALSE(response->buffer());
EXPECT_FALSE(clonedResponse->buffer());
}
+*/
+/*
TEST_F(ServiceWorkerResponseTest, BlobHandleCloneDefault)
{
FetchResponseData* fetchResponseData = FetchResponseData::create();
@@ -270,9 +275,9 @@ TEST_F(ServiceWorkerResponseTest, BlobHandleCloneOpaque)
void checkResponseStream(Response* response, bool checkResponseBodyStreamBuffer)
{
- BodyStreamBuffer* buffer = response->internalBuffer();
- EXPECT_FALSE(response->internalBlobDataHandle());
- EXPECT_FALSE(response->blobDataHandle());
+ BodyStreamBuffer2* buffer = response->internalBuffer();
+ // EXPECT_FALSE(response->internalBlobDataHandle());
+ // EXPECT_FALSE(response->blobDataHandle());
if (checkResponseBodyStreamBuffer) {
EXPECT_EQ(response->buffer(), buffer);
} else {
@@ -282,10 +287,10 @@ void checkResponseStream(Response* response, bool checkResponseBodyStreamBuffer)
TrackExceptionState exceptionState;
Response* clonedResponse = response->clone(exceptionState);
EXPECT_FALSE(exceptionState.hadException());
- EXPECT_FALSE(response->internalBlobDataHandle());
- EXPECT_FALSE(response->blobDataHandle());
- EXPECT_FALSE(clonedResponse->internalBlobDataHandle());
- EXPECT_FALSE(clonedResponse->blobDataHandle());
+ // EXPECT_FALSE(response->internalBlobDataHandle());
+ // EXPECT_FALSE(response->blobDataHandle());
+ // EXPECT_FALSE(clonedResponse->internalBlobDataHandle());
+ // EXPECT_FALSE(clonedResponse->blobDataHandle());
EXPECT_TRUE(response->internalBuffer());
EXPECT_TRUE(clonedResponse->internalBuffer());
@@ -397,6 +402,7 @@ TEST_F(ServiceWorkerResponseTest, CloneAndCancel)
clonedResponse->bufferForTest()->cancel();
EXPECT_EQ(1, canceller->counter());
}
+*/
} // namespace
} // namespace blink
« no previous file with comments | « Source/modules/fetch/Response.cpp ('k') | Source/modules/modules.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698