chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.h - Issue 1171873003: [Mac] Add cocoa implementation for sidebar extension action support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.h

Issue 1171873003: [Mac] Add cocoa implementation for sidebar extension action support Base URL: https://chromium.googlesource.com/chromium/src.git@patch-b

Patch Set: Rebased patch set to 1169823005/#ps200001 Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller_unittest.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.h

diff --git a/chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.h b/chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.h

index 0f87210c541fb5dc655c8e2cee83d88fed069320..1b258a3b1589a21b78089f7e1434a7833ebea222 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.h

+++ b/chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.h

@@ -31,6 +31,8 @@ class ExtensionActionPlatformDelegateCocoa

bool grant_tab_permissions,

ExtensionActionViewController::PopupShowAction show_action) override;

void CloseOverflowMenu() override;

+ void ShowSidebar(content::WebContents* sidebar_contents) override;

+ void HideSidebar() override;

// content::NotificationObserver:

void Observe(int type,