Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1171823005: Add autoroll package, alerts for failed rolls, recent rolls on Status (Closed)

Created:
5 years, 6 months ago by borenet
Modified:
5 years, 6 months ago
Reviewers:
rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add autoroll package, alerts for failed rolls, recent rolls on Status BUG=skia:3923 Committed: https://skia.googlesource.com/buildbot/+/4916d4a5c96f04f743fcf8a74cd5783dc36ab4b3

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 6

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -32 lines) Patch
M alertserver/go/alertserver/alertroutines.go View 1 2 2 chunks +27 lines, -0 lines 0 comments Download
A go/autoroll/autoroll.go View 1 2 1 chunk +78 lines, -0 lines 0 comments Download
M go/rietveld/rietveld.go View 1 3 chunks +6 lines, -9 lines 0 comments Download
M status/go/status/main.go View 1 2 5 chunks +28 lines, -11 lines 0 comments Download
M status/res/imp/autoroll-widget-sk.html View 1 6 chunks +98 lines, -11 lines 0 comments Download
M status/templates/commits.html View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
borenet
Screenshot of AutoRoll history: https://screenshot.googleplex.com/KcrMzBJTKup.png
5 years, 6 months ago (2015-06-10 17:51:03 UTC) #2
rmistry
Screenshot looks great. LGTM https://codereview.chromium.org/1171823005/diff/20001/alertserver/go/alertserver/alertroutines.go File alertserver/go/alertserver/alertroutines.go (right): https://codereview.chromium.org/1171823005/diff/20001/alertserver/go/alertserver/alertroutines.go#newcode211 alertserver/go/alertserver/alertroutines.go:211: Message: fmt.Sprintf("DEPS roll failed: https://codereview.chromium.org/%d", ...
5 years, 6 months ago (2015-06-10 20:20:54 UTC) #3
borenet
https://codereview.chromium.org/1171823005/diff/20001/alertserver/go/alertserver/alertroutines.go File alertserver/go/alertserver/alertroutines.go (right): https://codereview.chromium.org/1171823005/diff/20001/alertserver/go/alertserver/alertroutines.go#newcode211 alertserver/go/alertserver/alertroutines.go:211: Message: fmt.Sprintf("DEPS roll failed: https://codereview.chromium.org/%d", issue.Issue), On 2015/06/10 20:20:54, ...
5 years, 6 months ago (2015-06-11 11:40:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171823005/40001
5 years, 6 months ago (2015-06-11 14:02:27 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 14:03:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/buildbot/+/4916d4a5c96f04f743fcf8a74cd5783dc36a...

Powered by Google App Engine
This is Rietveld 408576698