status/templates/commits.html - Issue 1171823005: Add autoroll package, alerts for failed rolls, recent rolls on Status

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: status/templates/commits.html

Issue 1171823005: Add autoroll package, alerts for failed rolls, recent rolls on Status (Closed) Base URL: https://skia.googlesource.com/buildbot@master

Patch Set: Address comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: status/templates/commits.html

diff --git a/status/templates/commits.html b/status/templates/commits.html

index f96de2ecd146691869cb6801924cf7ffd3c566e2..ef6b994feda56f82fce9a3885c550338f699eeaa 100644

--- a/status/templates/commits.html

+++ b/status/templates/commits.html

@@ -100,7 +100,9 @@

}

})

$$$("autoroll-widget-sk").addEventListener("change", function(e) {

- $$$("commits-sk").setAutoRollStatus(e.detail.status.curr_roll_rev, e.detail.status.last_roll_rev);

+ if (e.detail.status) {

+ $$$("commits-sk").setAutoRollStatus(e.detail.status.curr_roll_rev, e.detail.status.last_roll_rev);

+ }

})

})();

« no previous file with comments | « status/res/imp/autoroll-widget-sk.html ('k') | no next file » | no next file with comments »