Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1171813002: [Startup Tracing] Remove |is_recording_| in devtool tracing_handler (Closed)

Created:
5 years, 6 months ago by Zhen Wang
Modified:
5 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, jam, pfeldman, tracing+reviews_chromium.org, wfh+watch_chromium.org, yurys
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Startup Tracing] Remove |is_recording_| in devtool tracing_handler With startup tracing via Telemetry, tracing may be started from places other than devtool (by reading the trace-config file). So devtool should not maintain the state of the tracing system. It can get the information from the TracingController. This requires adding one more function to TracingController's API. Startup tracing design doc: https://docs.google.com/document/d/1yRCXhrQ-0rsfUgNHt9T4YdnmJYrXKN6aK56Ozk3kPVc/edit?usp=sharing BUG=317481, 482098 Committed: https://crrev.com/02348013cae0dcce2b871c6bccfe2f7a034acdea Cr-Commit-Position: refs/heads/master@{#333574}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M content/browser/devtools/protocol/tracing_handler.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/devtools/protocol/tracing_handler.cc View 1 5 chunks +7 lines, -6 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/tracing/tracing_controller_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/browser/tracing_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
Zhen Wang
dsinclair@, can you take a look at the tracing part? yurys@, can you take a ...
5 years, 6 months ago (2015-06-08 23:33:15 UTC) #2
nednguyen
https://codereview.chromium.org/1171813002/diff/1/content/browser/devtools/protocol/tracing_handler.h File content/browser/devtools/protocol/tracing_handler.h (right): https://codereview.chromium.org/1171813002/diff/1/content/browser/devtools/protocol/tracing_handler.h#newcode57 content/browser/devtools/protocol/tracing_handler.h:57: bool IsRecording(); bool IsRecording() const; ?
5 years, 6 months ago (2015-06-09 02:58:24 UTC) #3
Zhen Wang
https://codereview.chromium.org/1171813002/diff/1/content/browser/devtools/protocol/tracing_handler.h File content/browser/devtools/protocol/tracing_handler.h (right): https://codereview.chromium.org/1171813002/diff/1/content/browser/devtools/protocol/tracing_handler.h#newcode57 content/browser/devtools/protocol/tracing_handler.h:57: bool IsRecording(); On 2015/06/09 02:58:23, nednguyen wrote: > bool ...
5 years, 6 months ago (2015-06-09 04:01:12 UTC) #4
dsinclair
lgtm
5 years, 6 months ago (2015-06-09 14:07:42 UTC) #5
nednguyen
On 2015/06/09 14:07:42, dsinclair wrote: > lgtm lgtm
5 years, 6 months ago (2015-06-09 15:16:12 UTC) #6
yurys
lgtm
5 years, 6 months ago (2015-06-09 16:35:18 UTC) #7
Zhen Wang
sievers@, can you stamp content/public/browser/tracing_controller.h? Thanks!
5 years, 6 months ago (2015-06-09 17:00:22 UTC) #9
no sievers
On 2015/06/09 17:00:22, Zhen Wang wrote: > sievers@, can you stamp content/public/browser/tracing_controller.h? Thanks! lgtm
5 years, 6 months ago (2015-06-09 18:31:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1171813002/20001
5 years, 6 months ago (2015-06-09 20:34:48 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-09 21:12:36 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-09 21:13:27 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/02348013cae0dcce2b871c6bccfe2f7a034acdea
Cr-Commit-Position: refs/heads/master@{#333574}

Powered by Google App Engine
This is Rietveld 408576698