Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Side by Side Diff: content/browser/devtools/protocol/tracing_handler.h

Issue 1171813002: [Startup Tracing] Remove |is_recording_| in devtool tracing_handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review fix Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/devtools/protocol/tracing_handler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_DEVTOOLS_PROTOCOL_TRACING_HANDLER_H_ 5 #ifndef CONTENT_BROWSER_DEVTOOLS_PROTOCOL_TRACING_HANDLER_H_
6 #define CONTENT_BROWSER_DEVTOOLS_PROTOCOL_TRACING_HANDLER_H_ 6 #define CONTENT_BROWSER_DEVTOOLS_PROTOCOL_TRACING_HANDLER_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 10
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 void OnRecordingEnabled(DevToolsCommandId command_id); 47 void OnRecordingEnabled(DevToolsCommandId command_id);
48 void OnBufferUsage(float percent_full, size_t approximate_event_count); 48 void OnBufferUsage(float percent_full, size_t approximate_event_count);
49 49
50 void OnCategoriesReceived(DevToolsCommandId command_id, 50 void OnCategoriesReceived(DevToolsCommandId command_id,
51 const std::set<std::string>& category_set); 51 const std::set<std::string>& category_set);
52 52
53 void SetupTimer(double usage_reporting_interval); 53 void SetupTimer(double usage_reporting_interval);
54 54
55 void DisableRecording(bool abort); 55 void DisableRecording(bool abort);
56 56
57 bool IsRecording() const;
58
57 scoped_ptr<base::Timer> buffer_usage_poll_timer_; 59 scoped_ptr<base::Timer> buffer_usage_poll_timer_;
58 Target target_; 60 Target target_;
59 bool is_recording_;
60 61
61 scoped_ptr<Client> client_; 62 scoped_ptr<Client> client_;
62 base::WeakPtrFactory<TracingHandler> weak_factory_; 63 base::WeakPtrFactory<TracingHandler> weak_factory_;
63 64
64 DISALLOW_COPY_AND_ASSIGN(TracingHandler); 65 DISALLOW_COPY_AND_ASSIGN(TracingHandler);
65 }; 66 };
66 67
67 } // namespace tracing 68 } // namespace tracing
68 } // namespace devtools 69 } // namespace devtools
69 } // namespace content 70 } // namespace content
70 71
71 #endif // CONTENT_BROWSER_DEVTOOLS_PROTOCOL_TRACING_HANDLER_H_ 72 #endif // CONTENT_BROWSER_DEVTOOLS_PROTOCOL_TRACING_HANDLER_H_
OLDNEW
« no previous file with comments | « no previous file | content/browser/devtools/protocol/tracing_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698