Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1416)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1171743002: Change the way we provide custom dart code for IDL bindings. (Closed)

Created:
5 years, 6 months ago by Matt Perry
Modified:
5 years, 6 months ago
Reviewers:
eseidel
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Change the way we provide custom dart code for IDL bindings. Rather than appending the custom Foo.dart code to the end of the generated interface, we now copy it to a CustomFoo.dart file in the output directory. This allows us to declare it as a proper dependency. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/97b99921ffaa4eb62c5aa10afcc7eb1e1887a6c1

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -20 lines) Patch
M sky/engine/bindings/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/IDLExtendedAttributes.txt View 2 chunks +3 lines, -4 lines 2 comments Download
M sky/engine/bindings/scripts/code_generator_dart.py View 2 chunks +4 lines, -8 lines 0 comments Download
M sky/engine/bindings/scripts/templates/interface_dart.template View 2 chunks +1 line, -3 lines 0 comments Download
M sky/engine/core/core.gni View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/engine/core/painting/Gradient.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sky/engine/core/painting/Gradient.idl View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/painting/MaskFilter.dart View 2 chunks +2 lines, -1 line 0 comments Download
M sky/engine/core/painting/MaskFilter.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Matt Perry
5 years, 6 months ago (2015-06-08 20:57:29 UTC) #2
eseidel
lgtm https://codereview.chromium.org/1171743002/diff/1/sky/engine/bindings/IDLExtendedAttributes.txt File sky/engine/bindings/IDLExtendedAttributes.txt (right): https://codereview.chromium.org/1171743002/diff/1/sky/engine/bindings/IDLExtendedAttributes.txt#newcode66 sky/engine/bindings/IDLExtendedAttributes.txt:66: # Sky addition: if present, the generated interface ...
5 years, 6 months ago (2015-06-08 20:59:32 UTC) #3
Matt Perry
https://codereview.chromium.org/1171743002/diff/1/sky/engine/bindings/IDLExtendedAttributes.txt File sky/engine/bindings/IDLExtendedAttributes.txt (right): https://codereview.chromium.org/1171743002/diff/1/sky/engine/bindings/IDLExtendedAttributes.txt#newcode66 sky/engine/bindings/IDLExtendedAttributes.txt:66: # Sky addition: if present, the generated interface will ...
5 years, 6 months ago (2015-06-08 21:14:03 UTC) #4
eseidel
Up to you, but I would drop it. All this code is ours. :)
5 years, 6 months ago (2015-06-08 21:15:38 UTC) #5
Matt Perry
5 years, 6 months ago (2015-06-08 21:26:56 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
97b99921ffaa4eb62c5aa10afcc7eb1e1887a6c1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698