Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: sky/engine/bindings/IDLExtendedAttributes.txt

Issue 1171743002: Change the way we provide custom dart code for IDL bindings. (Closed) Base URL: git@github.com:/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/bindings/BUILD.gn ('k') | sky/engine/bindings/scripts/code_generator_dart.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/IDLExtendedAttributes.txt
diff --git a/sky/engine/bindings/IDLExtendedAttributes.txt b/sky/engine/bindings/IDLExtendedAttributes.txt
index 46450c12e721ad24b68ea6d303752603fd4414fa..e653195f2f7adeaed00e8f8701b4cc5515eb1dd6 100644
--- a/sky/engine/bindings/IDLExtendedAttributes.txt
+++ b/sky/engine/bindings/IDLExtendedAttributes.txt
@@ -42,10 +42,6 @@ Constructor
ConstructorCallWith=ExecutionContext|Document
Custom=|Getter|Setter|VisitDOMWrapper|Wrap|PropertyGetter|PropertyEnumerator|PropertyQuery
CustomConstructor
-# Sky addition: if present, the IDL compiler will generate a private Dart
-# interface to be extended by an auxilary file <Interface>.dart next to
-# <Interface>.idl.
-CustomDart
CustomElementCallbacks
Default=Undefined
DependentLifetime
@@ -67,6 +63,9 @@ NotEnumerable
NotScriptWrappable
OverrideBuiltins
PartialInterfaceImplementedAs=*
+# Sky addition: if present, the generated interface will be prefixed with
eseidel 2015/06/08 20:59:32 There is nothing other than Sky. :) We're complete
Matt Perry 2015/06/08 21:14:03 I know, but I figured I'd call out where we're dif
+# underscores so that it's private to the dart:sky module.
+PrivateDart
PutForwards=*
RaisesException=|Getter|Setter|Constructor
Reflect=|*
« no previous file with comments | « sky/engine/bindings/BUILD.gn ('k') | sky/engine/bindings/scripts/code_generator_dart.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698