Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1171733003: Remove typdefs for pointer types in fx_system.h (Closed)

Created:
5 years, 6 months ago by Tom Sepez
Modified:
5 years, 6 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove typdefs for pointer types in fx_system.h. This involves fixing some multiple variable per line declarations, as the textually-substituted "*" applies only to the first one. This involves moving some consts around following the substitution. This involves replacing some typedefs used as constructors with better code. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/fbf266fc0ea4be2523cbb901a641aa33f0035662

Patch Set 1 : Prior to changes requiring thinking #

Patch Set 2 : Manual fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2464 lines, -2456 lines) Patch
M core/include/fdrm/fx_crypt.h View 1 chunk +28 lines, -28 lines 0 comments Download
M core/include/fpdfapi/fpdf_module.h View 3 chunks +8 lines, -8 lines 0 comments Download
M core/include/fpdfapi/fpdf_objects.h View 12 chunks +16 lines, -16 lines 0 comments Download
M core/include/fpdfapi/fpdf_page.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fpdfapi/fpdf_parser.h View 15 chunks +49 lines, -49 lines 0 comments Download
M core/include/fpdfapi/fpdf_resource.h View 6 chunks +9 lines, -9 lines 0 comments Download
M core/include/fpdfapi/fpdf_serial.h View 5 chunks +6 lines, -6 lines 0 comments Download
M core/include/fpdfdoc/fpdf_doc.h View 3 chunks +4 lines, -4 lines 0 comments Download
M core/include/fpdfdoc/fpdf_vt.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/include/fxcodec/fx_codec.h View 10 chunks +40 lines, -40 lines 0 comments Download
M core/include/fxcodec/fx_codec_provider.h View 3 chunks +9 lines, -9 lines 0 comments Download
M core/include/fxcrt/fx_basic.h View 25 chunks +35 lines, -35 lines 0 comments Download
M core/include/fxcrt/fx_ext.h View 3 chunks +13 lines, -13 lines 0 comments Download
M core/include/fxcrt/fx_memory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/include/fxcrt/fx_stream.h View 6 chunks +13 lines, -13 lines 0 comments Download
M core/include/fxcrt/fx_string.h View 29 chunks +64 lines, -64 lines 0 comments Download
M core/include/fxcrt/fx_system.h View 3 chunks +10 lines, -21 lines 0 comments Download
M core/include/fxge/fpf.h View 3 chunks +3 lines, -3 lines 0 comments Download
M core/include/fxge/fx_dib.h View 11 chunks +61 lines, -58 lines 0 comments Download
M core/include/fxge/fx_font.h View 8 chunks +19 lines, -19 lines 0 comments Download
M core/include/fxge/fx_ge.h View 5 chunks +9 lines, -9 lines 0 comments Download
M core/include/fxge/fx_ge_win32.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/include/reflow/fpdf_layout.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fdrm/crypto/fx_crypt.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M core/src/fdrm/crypto/fx_crypt_aes.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M core/src/fdrm/crypto/fx_crypt_sha.cpp View 15 chunks +18 lines, -18 lines 0 comments Download
M core/src/fpdfapi/fpdf_basic_module.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/editint.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 28 chunks +40 lines, -40 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp View 13 chunks +15 lines, -15 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/font_int.h View 6 chunks +8 lines, -8 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 23 chunks +33 lines, -31 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_charset.cpp View 1 7 chunks +7 lines, -7 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 1 18 chunks +26 lines, -26 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/ttgsubtable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp View 14 chunks +16 lines, -16 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp View 8 chunks +11 lines, -11 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 1 11 chunks +15 lines, -15 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/pageint.h View 8 chunks +10 lines, -10 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/filters_int.h View 9 chunks +17 lines, -15 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp View 15 chunks +25 lines, -25 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_encrypt.cpp View 30 chunks +56 lines, -56 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_filters.cpp View 17 chunks +21 lines, -21 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 28 chunks +46 lines, -45 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 35 chunks +42 lines, -42 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_cache.cpp View 9 chunks +13 lines, -9 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp View 10 chunks +16 lines, -16 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 18 chunks +24 lines, -24 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/render_int.h View 7 chunks +16 lines, -16 lines 0 comments Download
M core/src/fpdfdoc/doc_annot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_basic.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdfdoc/doc_form.cpp View 19 chunks +24 lines, -22 lines 0 comments Download
M core/src/fpdfdoc/doc_link.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M core/src/fpdfdoc/doc_metadata.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M core/src/fpdfdoc/doc_ocg.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdfdoc/doc_tagged.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_vt.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdfdoc/pdf_vt.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdftext/fpdf_text.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M core/src/fpdftext/fpdf_text_int.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M core/src/fpdftext/text_int.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdftext/unicodenormalization.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M core/src/fxcodec/codec/codec_int.h View 9 chunks +43 lines, -43 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec.cpp View 9 chunks +12 lines, -12 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_fax.cpp View 15 chunks +31 lines, -29 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_flate.cpp View 25 chunks +39 lines, -39 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_icc.cpp View 15 chunks +22 lines, -22 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_jbig.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpeg.cpp View 17 chunks +23 lines, -23 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpx_opj.cpp View 4 chunks +9 lines, -7 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Define.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Module.h View 1 chunk +5 lines, -5 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Object.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Object.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Segment.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/extension.h View 10 chunks +14 lines, -14 lines 0 comments Download
M core/src/fxcrt/fx_basic_array.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M core/src/fxcrt/fx_basic_bstring.cpp View 28 chunks +36 lines, -36 lines 0 comments Download
M core/src/fxcrt/fx_basic_bstring_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_buffer.cpp View 13 chunks +14 lines, -14 lines 0 comments Download
M core/src/fxcrt/fx_basic_gcc.cpp View 7 chunks +20 lines, -20 lines 0 comments Download
M core/src/fxcrt/fx_basic_maps.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M core/src/fxcrt/fx_basic_memmgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_utf.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_util.cpp View 7 chunks +9 lines, -9 lines 0 comments Download
M core/src/fxcrt/fx_basic_wstring.cpp View 28 chunks +38 lines, -38 lines 0 comments Download
M core/src/fxcrt/fx_extension.cpp View 15 chunks +29 lines, -29 lines 0 comments Download
M core/src/fxcrt/fx_xml_parser.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M core/src/fxcrt/fxcrt_platforms.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fxcrt_posix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fxcrt_windows.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/xml_int.h View 6 chunks +8 lines, -8 lines 0 comments Download
M core/src/fxge/agg/agg23/fx_agg_driver.cpp View 23 chunks +60 lines, -60 lines 0 comments Download
M core/src/fxge/agg/include/fx_agg_driver.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/src/fxge/android/fpf_skiafont.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/android/fpf_skiafont.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fxge/android/fpf_skiafontmgr.h View 6 chunks +7 lines, -7 lines 0 comments Download
M core/src/fxge/android/fpf_skiafontmgr.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M core/src/fxge/android/fx_android_font.h View 1 chunk +3 lines, -3 lines 0 comments Download
M core/src/fxge/android/fx_android_font.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M core/src/fxge/apple/apple_int.h View 3 chunks +7 lines, -7 lines 0 comments Download
M core/src/fxge/apple/fx_mac_imp.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M core/src/fxge/apple/fx_quartz_device.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M core/src/fxge/dib/dib_int.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/src/fxge/dib/fx_dib_composite.cpp View 93 chunks +197 lines, -197 lines 0 comments Download
M core/src/fxge/dib/fx_dib_convert.cpp View 36 chunks +80 lines, -80 lines 0 comments Download
M core/src/fxge/dib/fx_dib_engine.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M core/src/fxge/dib/fx_dib_main.cpp View 32 chunks +54 lines, -54 lines 0 comments Download
M core/src/fxge/dib/fx_dib_transform.cpp View 12 chunks +22 lines, -22 lines 0 comments Download
M core/src/fxge/ge/fx_ge.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/ge/fx_ge_device.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M core/src/fxge/ge/fx_ge_font.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M core/src/fxge/ge/fx_ge_fontmap.cpp View 1 35 chunks +47 lines, -47 lines 0 comments Download
M core/src/fxge/ge/fx_ge_linux.cpp View 1 10 chunks +16 lines, -16 lines 0 comments Download
M core/src/fxge/ge/fx_ge_path.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M core/src/fxge/ge/fx_ge_ps.cpp View 17 chunks +27 lines, -27 lines 0 comments Download
M core/src/fxge/ge/fx_ge_text.cpp View 14 chunks +28 lines, -28 lines 0 comments Download
M core/src/fxge/skia/fx_skia_blitter_new.h View 2 chunks +104 lines, -104 lines 0 comments Download
M core/src/fxge/skia/fx_skia_blitter_new.cpp View 27 chunks +82 lines, -82 lines 0 comments Download
M core/src/fxge/skia/fx_skia_device.h View 2 chunks +4 lines, -4 lines 0 comments Download
M core/src/fxge/skia/fx_skia_device.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M core/src/fxge/win32/dwrite_int.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/win32/fx_win32_device.cpp View 10 chunks +18 lines, -18 lines 0 comments Download
M core/src/fxge/win32/fx_win32_dib.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M core/src/fxge/win32/fx_win32_dwrite.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fxge/win32/fx_win32_gdipext.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M core/src/fxge/win32/fx_win32_print.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M core/src/fxge/win32/win32_int.h View 6 chunks +9 lines, -9 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_CBA_Fontmap.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fsdk_baseform.h View 4 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 8 chunks +8 lines, -8 lines 0 comments Download
M fpdfsdk/include/fx_systemhandler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/fxedit/fx_edit.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/fxedit/fxet_edit.h View 3 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/include/fxedit/fxet_list.h View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/javascript/JS_EventHandler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/javascript/JS_GlobalData.h View 2 chunks +12 lines, -12 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Object.h View 3 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/include/javascript/JS_Value.h View 3 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/include/javascript/PublicMethods.h View 2 chunks +12 lines, -12 lines 0 comments Download
M fpdfsdk/include/javascript/global.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ComboBox.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Edit.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_EditCtrl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_FontMap.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Icon.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Label.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ListBox.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Note.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Signature.h View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Wnd.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_CBA_Fontmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdf_dataavail.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdf_ext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdf_flatten.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/src/fpdf_sysfontinfo.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/fpdf_transformpage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfdoc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfppo.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/fsdk_actionhandler.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_edit.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_list.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/Consts.cpp View 5 chunks +24 lines, -24 lines 0 comments Download
M fpdfsdk/src/javascript/JS_EventHandler.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/javascript/JS_GlobalData.cpp View 12 chunks +14 lines, -14 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Object.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Value.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.cpp View 11 chunks +26 lines, -26 lines 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 8 chunks +11 lines, -11 lines 0 comments Download
M fpdfsdk/src/javascript/util.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8.cpp View 1 6 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ComboBox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Edit.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_EditCtrl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_FontMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Icon.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Label.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_ListBox.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Note.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Signature.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, for review. Getting near the end ...
5 years, 6 months ago (2015-06-09 22:10:35 UTC) #2
Lei Zhang
lgtm
5 years, 6 months ago (2015-06-10 06:08:19 UTC) #3
Tom Sepez
5 years, 6 months ago (2015-06-10 18:09:52 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
fbf266fc0ea4be2523cbb901a641aa33f0035662 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698