Remove typdefs for pointer types in fx_system.h

core/src/fpdfdoc/doc_metadata.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../include/fpdfdoc/fpdf_doc.h"
 #include "../../include/fxcrt/fx_xml.h"
 typedef struct _PDFDOC_METADATA {
     CPDF_Document *m_pDoc;
     CXML_Element *m_pXmlElmnt;
     CXML_Element *m_pElmntRdf;
     CFX_CMapByteStringToPtr *m_pStringMap;
 } PDFDOC_METADATA, * PDFDOC_LPMETADATA;
 typedef PDFDOC_METADATA const * PDFDOC_LPCMETADATA;
-const FX_LPCSTR gs_FPDFDOC_Metadata_Titles[] = {
+const FX_CHAR* const gs_FPDFDOC_Metadata_Titles[] = {
     "Title", "title",
     "Subject", "description",
     "Author", "creator",
     "Keywords", "Keywords",
     "Producer", "Producer",
     "Creator", "CreatorTool",
     "CreationDate", "CreateDate",
     "ModDate", "ModifyDate",
     "MetadataDate", "MetadataDate"
 };
@@ skipping 26 matching lines @@
     FXSYS_assert(pDoc != NULL);
     ((PDFDOC_LPMETADATA)m_pData)->m_pDoc = pDoc;
     CPDF_Dictionary *pRoot = pDoc->GetRoot();
     CPDF_Stream *pStream = pRoot->GetStream(FX_BSTRC("Metadata"));
     if (!pStream) {
         return;
     }
     CPDF_StreamAcc acc;
     acc.LoadAllData(pStream, FALSE);
     int size = acc.GetSize();
-    FX_LPCBYTE pBuf = acc.GetData();
+    const uint8_t* pBuf = acc.GetData();
     CXML_Element *&pXmlElmnt = ((PDFDOC_LPMETADATA)m_pData)->m_pXmlElmnt;
     pXmlElmnt = CXML_Element::Parse(pBuf, size);
     if (!pXmlElmnt) {
         return;
     }
     CXML_Element *&pElmntRdf = ((PDFDOC_LPMETADATA)m_pData)->m_pElmntRdf;
     if (pXmlElmnt->GetTagName() == FX_BSTRC("RDF")) {
         pElmntRdf = pXmlElmnt;
     } else {
         pElmntRdf = pXmlElmnt->GetElement(NULL, FX_BSTRC("RDF"));
     }
 }
 int32_t CPDF_Metadata::GetString(FX_BSTR bsItem, CFX_WideString &wsStr)
 {
     if (!((PDFDOC_LPMETADATA)m_pData)->m_pXmlElmnt) {
         return -1;
     }
     if (!((PDFDOC_LPMETADATA)m_pData)->m_pStringMap) {
         return -1;
     }
     void *szTag;
     if (!((PDFDOC_LPMETADATA)m_pData)->m_pStringMap->Lookup(bsItem, szTag)) {
         return -1;
     }
-    CFX_ByteString bsTag = (FX_LPCSTR)szTag;
+    CFX_ByteString bsTag = (const FX_CHAR*)szTag;
     wsStr = L"";
     CXML_Element *pElmntRdf = ((PDFDOC_LPMETADATA)m_pData)->m_pElmntRdf;
     if (!pElmntRdf) {
         return -1;
     }
     int nChild = pElmntRdf->CountChildren();
     for (int i = 0; i < nChild; i++) {
         CXML_Element *pTag = pElmntRdf->GetElement(NULL, FX_BSTRC("Description"), i);
         if (!pTag) {
             continue;
@@ skipping 40 matching lines @@
     return -1;
 }
 CXML_Element* CPDF_Metadata::GetRoot() const
 {
     return ((PDFDOC_LPMETADATA)m_pData)->m_pXmlElmnt;
 }
 CXML_Element* CPDF_Metadata::GetRDF() const
 {
     return ((PDFDOC_LPMETADATA)m_pData)->m_pElmntRdf;
 }