Issue 1171713002: remove ClosureWrap option and related implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1171713002: remove ClosureWrap option and related implementation (Closed)

Created:
5 years, 6 months ago by Jennifer Messerly

Modified:
5 years, 6 months ago

Reviewers:
Leaf

CC:
dev-compiler+reviews_dartlang.org, vsm

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

remove ClosureWrap option and related implementation Vijay thought that we don't need this anymore, as we decided not to wrap. R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/312268954f03f3b85e5c5b1a361acb1469f18bc0

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -406 lines)			Patch
M	lib/src/checker/rules.dart	View	3 chunks	+2 lines, -76 lines	0 comments	Download
M	lib/src/codegen/reify_coercions.dart	View	3 chunks	+2 lines, -193 lines	0 comments	Download
M	lib/src/info.dart	View	4 chunks	+0 lines, -99 lines	0 comments	Download
M	lib/src/options.dart	View	5 chunks	+2 lines, -15 lines	0 comments	Download
M	lib/src/testing.dart	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	test/checker/checker_test.dart	View	1 chunk	+0 lines, -19 lines	0 comments	Download
M	test/checker/inferred_type_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Jennifer Messerly

5 years, 6 months ago (2015-06-08 21:32:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
312268954f03f3b85e5c5b1a361acb1469f18bc0 (presubmit successful).