Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: lib/src/options.dart

Issue 1171713002: remove ClosureWrap option and related implementation (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/info.dart ('k') | lib/src/testing.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/options.dart
diff --git a/lib/src/options.dart b/lib/src/options.dart
index 0902066bb86be3c687a3ace50c8c3fa695a473ae..832bab1c9eca5afdbb5b201e6680a400ee377b31 100644
--- a/lib/src/options.dart
+++ b/lib/src/options.dart
@@ -86,13 +86,9 @@ class RulesOptions extends TypeOptions {
/// Whether to use static types for code generation.
final bool ignoreTypes;
- /// Whether to wrap closures for compatibility.
- final bool wrapClosures;
- static const wrapClosuresDefault = false;
-
RulesOptions({this.covariantGenerics: true,
this.inferDownwards: inferDownwardsDefault, this.relaxedCasts: true,
- this.ignoreTypes: false, this.wrapClosures: wrapClosuresDefault});
+ this.ignoreTypes: false});
}
class JSCodeOptions {
@@ -204,10 +200,6 @@ class CompilerOptions implements RulesOptions, ResolverOptions, JSCodeOptions {
@override
final bool ignoreTypes;
- /// Whether to wrap closures for compatibility.
- @override
- final bool wrapClosures;
-
/// Whether to emit the source map files.
@override
final bool emitSourceMaps;
@@ -222,8 +214,7 @@ class CompilerOptions implements RulesOptions, ResolverOptions, JSCodeOptions {
CompilerOptions({this.checkSdk: false, this.dumpInfo: false,
this.dumpInfoFile, this.forceCompile: false, this.ignoreTypes: false,
- this.wrapClosures: RulesOptions.wrapClosuresDefault, this.outputDir,
- this.useColors: true, this.covariantGenerics: true,
+ this.outputDir, this.useColors: true, this.covariantGenerics: true,
this.relaxedCasts: true, this.useMultiPackage: false,
this.packageRoot: 'packages/', this.packagePaths: const <String>[],
this.resources: const <String>[],
@@ -291,7 +282,6 @@ CompilerOptions parseOptions(List<String> argv) {
dumpInfoFile: args['dump-info-file'],
forceCompile: args['force-compile'] || serverMode,
ignoreTypes: args['ignore-types'],
- wrapClosures: args['wrap-closures'],
outputDir: outputDir,
covariantGenerics: args['covariant-generics'],
relaxedCasts: args['relaxed-casts'],
@@ -334,9 +324,6 @@ final ArgParser argParser = new ArgParser()
help: 'Use covariant generics', defaultsTo: true)
..addFlag('ignore-types',
help: 'Ignore types during codegen', defaultsTo: false)
- ..addFlag('wrap-closures',
- help: 'wrap closures implicitly',
- defaultsTo: RulesOptions.wrapClosuresDefault)
..addFlag('relaxed-casts',
help: 'Cast between Dart assignable types', defaultsTo: true)
..addOption('nonnullable',
« no previous file with comments | « lib/src/info.dart ('k') | lib/src/testing.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698