Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1171693008: device scale factor detection: use gtk-xft-dpi consistently (Closed)

Created:
5 years, 6 months ago by Michael Moss
Modified:
5 years, 6 months ago
Reviewers:
laforge, oshima
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2357
Target Ref:
refs/pending/branch-heads/2357
Project:
chromium
Visibility:
Public.

Description

device scale factor detection: use gtk-xft-dpi consistently Before this CL, we used either gtk-xft-dpi (UI fonts) or the physical DPI of a more or less random display. This CL consistently uses gtk-xft-dpi which is the better alternative: users can directly influence it (by changing the Xft.dpi X resource, or via their gtkrc). See also https://github.com/derat/font-config-info for displaying your current system settings. This is a re-do of https://codereview.chromium.org/1070433002/, but with https://codereview.chromium.org/1084453002/ applied (fixes content_shell). BUG=473089, 143619, 498426 Review URL: https://codereview.chromium.org/1085603002 Cr-Commit-Position: refs/heads/master@{#324928} (cherry picked from commit d459a5c49a02507b9ac77ffbbf33dffeb3bc9c34) TBR=laforge@chromium.org, oshima@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/da20b3fc0aed6674160b02eba4919f6ec2379ec7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -30 lines) Patch
M chrome/browser/ui/libgtk2ui/gtk2_ui.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 2 chunks +14 lines, -4 lines 0 comments Download
M ui/views/linux_ui/linux_ui.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 5 chunks +11 lines, -26 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Michael Moss
5 years, 6 months ago (2015-06-10 20:26:39 UTC) #1
laforge
On 2015/06/10 20:26:39, Michael Moss wrote: LGTM
5 years, 6 months ago (2015-06-10 20:39:02 UTC) #3
Michael Moss
5 years, 6 months ago (2015-06-10 20:40:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
da20b3fc0aed6674160b02eba4919f6ec2379ec7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698