Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 1171693007: Use local variable for out parameter rather than direct use of ivar (Closed)

Created:
5 years, 6 months ago by ivanpe
Modified:
5 years, 6 months ago
Reviewers:
dmaclach, qsr, blundell
CC:
google-breakpad-dev_googlegroups.com, brianjmoore_google.com
Visibility:
Public.

Description

Use local variable for out parameter rather than direct use of ivar - Resolves spurious static analyzer warning about response_ being potentially leaked due to the retain in Xcode 6.3 and later. I'm submitting this on behalf of Brian Moore. R=qsr@chromium.org Committed: https://code.google.com/p/google-breakpad/source/detail?r=1460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/common/mac/HTTPMultipartUpload.m View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ivanpe
5 years, 6 months ago (2015-06-10 18:32:58 UTC) #2
ivanpe
5 years, 6 months ago (2015-06-10 18:34:19 UTC) #3
qsr
lgtm
5 years, 6 months ago (2015-06-11 09:29:27 UTC) #4
ivanpe
5 years, 6 months ago (2015-06-20 00:32:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r1460 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698